Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests for the TcPairs wrapper #273

Closed
bikegeek opened this issue Jul 24, 2019 · 1 comment
Closed

Refactor tests for the TcPairs wrapper #273

bikegeek opened this issue Jul 24, 2019 · 1 comment
Assignees
@georgemccabe
Labels
component: testing Software testing issue priority: high High Priority requestor: NCAR National Center for Atmospheric Research type: bug Fix something that is not working
Milestone
METplus-4.1.0

Comments

@bikegeek
Copy link
Contributor

Now that the TcPairs wrapper has undergone significant refactoring to handle multiple input formats, the original tests no longer work and a refactoring of the tests is necessary.
@bikegeek bikegeek added type: bug Fix something that is not working component: testing Software testing issue priority: high High Priority requestor: NCAR National Center for Atmospheric Research labels Jul 24, 2019
@bikegeek bikegeek added this to the METplus-3.0 Release milestone Jul 24, 2019
@georgemccabe georgemccabe added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Sep 10, 2020
georgemccabe added a commit that referenced this issue Nov 2, 2020
@georgemccabe
removed tests that just run the wrapper and check if output was creat…
1ba41df 
…ed. Per #273, we will need to write new unit tests that cover the refactored code to test that the functions work as intended without having to run a use case
@bikegeek bikegeek removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Dec 15, 2020
@georgemccabe
Copy link
Collaborator

This was completed as part of the TCPairs refactor. PR: #937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
component: testing Software testing issue priority: high High Priority requestor: NCAR National Center for Atmospheric Research type: bug Fix something that is not working
Projects
None yet
Milestone
METplus-4.1.0
Development

No branches or pull requests
3 participants
@bikegeek @georgemccabe @hankenstein2