Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Refactor wrappers to consistently find input files #2492

Open
22 tasks
georgemccabe opened this issue Feb 8, 2024 · 0 comments
Open
22 tasks
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Feb 8, 2024

EDIT: This issue originally covered both adding documentation for new config variables and updating all wrappers to consistently find input files using RuntimeFreq's functions. The new development work is out of the scope for the 6.0.0 release, so I created issue #2757 to update the documentation for the 6.0 release. Then I renamed this issue and moved it to 6.1 development.

The functionality for #2460 has been added and works as expected. However, there are some additional changes that should be done before the official release.

Describe the Task

Time Estimate

Assess time and only work if less than 3 days

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2771024

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Feb 8, 2024
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Feb 8, 2024
@georgemccabe georgemccabe self-assigned this Feb 8, 2024
@jprestop jprestop added the priority: high High Priority label Jul 3, 2024
@georgemccabe georgemccabe changed the title Finish remaining tasks for #2460 Enhancement: Refactor wrappers to consistently find input files Oct 29, 2024
@georgemccabe georgemccabe removed the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Oct 29, 2024
@georgemccabe georgemccabe added reporting: DTC AF METplus Air Force METplus Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Nov 15, 2024
@JohnHalleyGotway JohnHalleyGotway added the component: code cleanup Code cleanup and maintenance issue label Nov 15, 2024
georgemccabe added a commit that referenced this issue Dec 13, 2024
… files, progress towards #2492. Allow file window range to be specified separately for mask and input files. Other cleanup to move towards consistent wrappers with fewer wrapper-specific overrides of functions like get_command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: 🟢 Ready
Development

No branches or pull requests

3 participants