Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Truth: For dtcenter/METbaseimage#14 and dtcenter/MET#2672 #2337

Closed
4 of 9 tasks
JohnHalleyGotway opened this issue Sep 5, 2023 · 1 comment · Fixed by #2343 or #2344
Closed
4 of 9 tasks

Update Truth: For dtcenter/METbaseimage#14 and dtcenter/MET#2672 #2337

JohnHalleyGotway opened this issue Sep 5, 2023 · 1 comment · Fixed by #2343 or #2344
Assignees
Labels
component: CI/CD Continuous integration and deployment issues priority: blocker Blocker requestor: METplus Team METplus Development Team type: update truth Update truth dataset
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe Expected Changes

dtcenter/METbaseimage#14 updates the GHA Docker environment to use Debian version 12 (bookworm). This changes the compiler version from gcc (Debian 8.3.0-6) 8.3.0 to gcc (Debian 12.2.0-14) 12.2.0. It also the compile_MET_all.sh script that was updated by dtcenter/MET#2672 to compile the new dependency on the Proj library.

As described in this PR comment changes are introduced to the MET unit test output as a result of upgrading the gfortran compiler version.

It is likely that similar differences will exist in the output of the METplus use cases.

This issue is to check for those differences, verify that all are reasonable, and update the truth dataset accordingly.

Define the Metadata

Title

  • Add a link to the pull request that warranted this issue to the issue title using format dtcenter/{REPO}#{PR_NUMBER}.

Example: Update Truth: For dtcenter/MET#2655

Assignee

Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Update Truth Checklist

  • Review the GitHub Actions workflow that was triggered by the PR merge
    • If no differences were found, note this in a comment.
    • If all of the differences are expected, note this in a comment.
      Include any details of how the review was performed.
    • If unexpected differences are found, the following instructions can
      help uncover potential explanations. If none of these apply and the
      source of the differences cannot be determined, contact the
      METplus wrappers lead engineer (@georgemccabe) for assistance.
      • Search for other open issues that have the label type: update truth
        applied by clicking on the label on this issue. Coordinate with the
        author of these issues to ensure all diffs are properly reviewed.
      • Check if any additional GitHub Actions testing workflows have been
        triggered since the workflow that corresponds to this issue was run.
        Review the latest run to ensure that there are no diffs that are
        unrelated to this issue.
      • If the incorrect differences are caused by the changes from the
        issue that warranted this issue, consider reverting the PR and
        re-opening the issue.
    • Iterate until one of the above conditions apply.
  • Approve the update of the truth data
    • Contact the METplus wrappers lead engineer (@georgemccabe) or
      backup lead (@jprestop) to let them know that the truth data can
      be updated.
  • Update the truth data.
    This should be handled by a METplus wrappers engineer.
    See the (instructions to update the truth data)[https://metplus.readthedocs.io/en/develop/Contributors_Guide/continuous_integration.html#update-truth-data-update-truth-data-yml]
    for more info.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added priority: blocker Blocker component: CI/CD Continuous integration and deployment issues requestor: METplus Team METplus Development Team type: update truth Update truth dataset labels Sep 5, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-6.0.0 milestone Sep 5, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 5, 2023
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Sep 5, 2023

This GHA run produced many failures. Some of the failures are caused by differences in the output, which is to be expected. However, many of the failures are runtime errors. Investigating the error logs artifact, I note the following:

  1. The 53 *.log files consist of 23 metplus.log files and 30 wrapper-specific log files (e.g. user_script, stat_analysis, grid_stat, and so on).
  2. The following libtiff.so.5 error appears 22 times:
ImportError: libtiff.so.5: cannot open shared object file: No such file or directory

I see that...

  • dtcenter/met-base:v2.0_debian10 contains /usr/lib/x86_64-linux-gnu/libtiff.so.5.
  • dtcenter/met-base:v2.1 contains /usr/lib/x86_64-linux-gnu/libtiff.so.6.
    I wonder where the libtiff.so.5 dependency originates?
  1. This error appears once in unstructured_grids/StatAnalysis_fcstLFRIC_UGRID_obsASCII_PyEmbed/stat_analysis.log:
ImportError: libGL.so.1: cannot open shared object file: No such file or directory
  1. This error appears once in tc_and_extra_tc/UserScript_ASCII2NC_PointStat_fcstHAFS_obsFRD_NetCDF/ascii2nc.log:
AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?

@georgemccabe and @JohnHalleyGotway met to discuss and decided that the likely culprit is the inconsistency in the operating system for the Debian 12 METbaseimage and these docker_env environments which use Debian 10.

@georgemccabe is writing up an issue to upgrade those environments from Debian 10 to 12, and we hope that'll resolve these issues.

@georgemccabe georgemccabe linked a pull request Sep 13, 2023 that will close this issue
georgemccabe pushed a commit that referenced this issue Sep 13, 2023
Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: Dan Adriaansen <[email protected]>
Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Daniel Adriaansen <[email protected]>
Co-authored-by: Jonathan Vigh <[email protected]>
Co-authored-by: root <root@localhost>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Will Mayfield <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: metplus-bot <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: mrinalbiswas <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: jason-english <[email protected]>
Co-authored-by: John Sharples <[email protected]>
fix GitHub Actions warnings (#1864)
fix #1884 develop PCPCombine {custom} in subtract method (#1887)
fix #1939 develop - failure reading obs when zipped file also exists (#1941)
Closes #1986
fix develop Fix broken documentation links (#2004)
fix #2026 develop StatAnalysis looping (#2028)
fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062)
fix #2070 var list numeric order (#2072)
fix #2087 develop docs_pdf (#2091)
fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099)
Fix for Dockerfile smell DL4000 (#2112)
fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140)
fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101)
fix #2137 develop PointStat -obs_valid_beg/end (#2141)
fix failured introduced by urllib3 (see urllib3/urllib3#2168)
fix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162)
fix #2168 develop - StatAnalysis time shift (#2169)
fix releases. (#2183)
fix #2189 develop - spaces in complex thresholds (#2191)
fix #2179 develop TCPairs fix -diag argument (#2187)
fixes (#2200)
fix diff tests (#2217)
fix automated tests (#2237)
fix #2235 rename multivar_itensity to multivar_intensity_flag (#2236)
fix #2241 Create directory containing -out_stat file (#2242)
fix #2245 use unique run ID to name logger instance (#2247)
fix #2244 develop fix diff tests (#2254)
fixture to set pytest tmpdir (#2261)
fix #1853 develop - PointStat don't require mask variables to be set (#2262)
fix #2279 develop - buoy station file from 2022 (#2280)
fix (#2313)
@georgemccabe georgemccabe linked a pull request Sep 13, 2023 that will close this issue
georgemccabe pushed a commit that referenced this issue Sep 13, 2023
Co-authored-by: Lisa Goodrich <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: Dan Adriaansen <[email protected]>
Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Daniel Adriaansen <[email protected]>
Co-authored-by: Jonathan Vigh <[email protected]>
Co-authored-by: root <root@localhost>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Will Mayfield <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: metplus-bot <[email protected]>
Co-authored-by: Tracy Hertneky <[email protected]>
Co-authored-by: Giovanni Rosa <[email protected]>
Co-authored-by: mrinalbiswas <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: jason-english <[email protected]>
Co-authored-by: John Sharples <[email protected]>
fix GitHub Actions warnings (#1864)
fix #1884 develop PCPCombine {custom} in subtract method (#1887)
fix #1939 develop - failure reading obs when zipped file also exists (#1941)
Closes #1986
fix develop Fix broken documentation links (#2004)
fix #2026 develop StatAnalysis looping (#2028)
fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062)
fix #2070 var list numeric order (#2072)
fix #2087 develop docs_pdf (#2091)
fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099)
Fix for Dockerfile smell DL4000 (#2112)
fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140)
fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101)
fix #2137 develop PointStat -obs_valid_beg/end (#2141)
fix failured introduced by urllib3 (see urllib3/urllib3#2168)
fix #2161 develop PCPCombine additional field arguments in -subtract mode (#2162)
fix #2168 develop - StatAnalysis time shift (#2169)
fix releases. (#2183)
fix #2189 develop - spaces in complex thresholds (#2191)
fix #2179 develop TCPairs fix -diag argument (#2187)
fixes (#2200)
fix diff tests (#2217)
fix automated tests (#2237)
fix #2235 rename multivar_itensity to multivar_intensity_flag (#2236)
fix #2241 Create directory containing -out_stat file (#2242)
fix #2245 use unique run ID to name logger instance (#2247)
fix #2244 develop fix diff tests (#2254)
fixture to set pytest tmpdir (#2261)
fix #1853 develop - PointStat don't require mask variables to be set (#2262)
fix #2279 develop - buoy station file from 2022 (#2280)
fix (#2313)
@georgemccabe georgemccabe moved this from In Progress to Done in METplus-Wrappers-6.0.0 Development Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CI/CD Continuous integration and deployment issues priority: blocker Blocker requestor: METplus Team METplus Development Team type: update truth Update truth dataset
Projects
Status: 🏁 Done
2 participants