Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GenEnsProd logic to properly handle ensembles that are missing #1266

Closed
9 of 21 tasks
georgemccabe opened this issue Nov 15, 2021 · 0 comments · Fixed by #1275
Closed
9 of 21 tasks

Enhance GenEnsProd logic to properly handle ensembles that are missing #1266

georgemccabe opened this issue Nov 15, 2021 · 0 comments · Fixed by #1275
Assignees
Labels
METplus: Configuration priority: blocker Blocker reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

EnsembleStat wrapper properly handles ensembles that are not found so that a threshold (ens/vld_thresh) can be used to skip processing if the threshold of valid files is not met. The logic in GenEnsProd may not be considering this situation and therefore not handling it appropriately.

Describe the Enhancement

Enhance the logic to handle missing ensembles properly. This can be done by either setting a fake path in the input file list passed to the tool for files that were not found OR passing in the paths to all desired files regardless if the actual file was found on disk or not.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.1.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplus: Configuration labels Nov 15, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Nov 15, 2021
@georgemccabe georgemccabe self-assigned this Nov 15, 2021
georgemccabe added a commit that referenced this issue Nov 15, 2021
@georgemccabe georgemccabe linked a pull request Nov 16, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: blocker Blocker reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants