Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle list values that include square braces #1212

Closed
7 of 20 tasks
georgemccabe opened this issue Oct 20, 2021 · 0 comments · Fixed by #1262
Closed
7 of 20 tasks

Properly handle list values that include square braces #1212

georgemccabe opened this issue Oct 20, 2021 · 0 comments · Fixed by #1262
Assignees
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Multiple users have defined list values in METplus config files including the square braces that are found in the MET config files:

POINT_STAT_MASK_SID = ["/data/users/cfrd/METplus_playaround/StationLists/2011.stns", "/data/users/cfrd/METplus_playaround/StationLists/2012.stns"]

List values in METplus config files currently cannot not include square braces and will be formatted properly when set in the MET config files.

Describe the Enhancement

Enhance the list parsing logic to properly handle list values that contain the square braces so that the above example will work properly.

Time Estimate

<1 day

Sub-Issues

None

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle requestor: UK Met Office United Kingdom Met Office requestor: METplus Team METplus Development Team METplus: Configuration labels Oct 20, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Oct 20, 2021
@georgemccabe georgemccabe self-assigned this Oct 20, 2021
@georgemccabe georgemccabe mentioned this issue Nov 12, 2021
12 tasks
@georgemccabe georgemccabe linked a pull request Nov 12, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants