Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting file_type for fcst/obs for applications that process gridded data #1165

Closed
7 of 21 tasks
georgemccabe opened this issue Sep 22, 2021 · 0 comments · Fixed by #1437
Closed
7 of 21 tasks

Add support for setting file_type for fcst/obs for applications that process gridded data #1165

georgemccabe opened this issue Sep 22, 2021 · 0 comments · Fixed by #1437
Assignees
@georgemccabe
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: python wrapper METplus: Configuration priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone
METplus-4.1.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Sep 22, 2021 •
edited by hankenstein2
Loading

Currently, GridStat has an option to set FCST_GRID_STAT_FILE_TYPE or OBS_GRID_STAT_FILE_TYPE to set the file_type value in the fcst and obs dictionaries respectively.

Describe the Enhancement

Add support for setting the file_type value for all applications that process gridded data, i.e. PointStat.

Time Estimate

~ 1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7740181 - UAE-NCM

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper priority: high High Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle requestor: NCAR/RAL NCAR Research Applications Laboratory METplus: Configuration labels Sep 22, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Sep 22, 2021
@georgemccabe georgemccabe self-assigned this Sep 22, 2021
@georgemccabe georgemccabe removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 23, 2021
@hankenstein2 hankenstein2 moved this from Todo to In Progress in METplus-Wrappers-5.0.0-beta1 (6/22/22) Feb 14, 2022
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, fix name of MET variable that is set by METplus variable a…
621c043 
…nd added OBS equivalent
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, fixed unit test
3abee57
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, fixed read of new METplus config and add OBS equivalent
7d2c7c5
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, add OBS equivalent env var
6de8336
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, moved env var into fcst dictionary and added obs equivalent
992c62d
georgemccabe added a commit that referenced this issue Feb 14, 2022
@georgemccabe
per #1165, move example config variables closer to related variables
24bebd7
@georgemccabe georgemccabe linked a pull request Feb 15, 2022 that will close this issue
Added fcst_file_type to two wrappers #1437
Merged
12 tasks
Repository owner moved this from In Progress to Done in METplus-Wrappers-5.0.0-beta1 (6/22/22) Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: python wrapper METplus: Configuration priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
None yet
Milestone
METplus-4.1.0
Development

Successfully merging a pull request may close this issue.

Added fcst_file_type to two wrappers dtcenter/METplus
1 participant
@georgemccabe