Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output_flag.orank configurable for Point-Stat. #1103

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Aug 23, 2021 · 0 comments · Fixed by #1124
Closed
8 of 20 tasks

Make output_flag.orank configurable for Point-Stat. #1103

JohnHalleyGotway opened this issue Aug 23, 2021 · 0 comments · Fixed by #1124
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Grid-to-Point Verification priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: Army/ARL United States Army Research Laboratory required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

Issue dtcenter/MET#1764 and Pull Request dtcenter/MET#1885 enable Point-Stat to write the ORANK line type when applying the HiRA verification algorithm. Part of the code changes are adding an entry for orank in the output_flag dictionary. Please see the default point_stat config file.

Note that running Point-Stat with a config file that does not contain output_flag.orank does run fine.

This task is to add orank to the wrapped METplus Point-Stat config file and make its value configurable.

Added this to the beta2 development cycle but it could be moved to beta3 if needed.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues necessary.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: George
  • Select scientist(s) or no scientist required: no scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: use case configuration priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: Army/ARL United States Army Research Laboratory required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project MET: Grid-to-Point Verification labels Aug 23, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Aug 23, 2021
@georgemccabe georgemccabe linked a pull request Aug 30, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added the reporting: DTC NCAR Base NCAR Base DTC Project label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Grid-to-Point Verification priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: Army/ARL United States Army Research Laboratory required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants