Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting -out argument in TCStat and StatAnalysis wrappers #1102

Closed
7 of 21 tasks
georgemccabe opened this issue Aug 23, 2021 · 0 comments · Fixed by #1477
Closed
7 of 21 tasks

Add support for setting -out argument in TCStat and StatAnalysis wrappers #1102

georgemccabe opened this issue Aug 23, 2021 · 0 comments · Fixed by #1477
Assignees
@georgemccabe
Labels
component: python wrapper METplus: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METplus-4.1.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Aug 23, 2021 •
edited by TaraJensen
Loading

In METplus 4.0, changes to the wrapper were made to always run with a config file. However, there is no option in TC-Stat to write the most critical information (summary) out to a separate file without using the -out command line argument.

"-out file" specifies a file to which output should be written rather than the screen (optional) and is different than what is set by the -outdir CL option in other tools.

Additionally, StatAnalysis also has the -out command line argument. While there is an override of setting -out_stat in the job specification, for consistency within the analysis tools, this option should be supported in both wrappers.

Describe the Enhancement

Investigate how support should be added back (either set it explicitly or automatically set it to the output dir that is set in the config).

Once changes are made, contact @malloryprow to test that changes accomplish what is needed.

Time Estimate

< 1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.1.0

Funding Source

2793541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration labels Aug 23, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Aug 23, 2021
@georgemccabe georgemccabe self-assigned this Aug 23, 2021
@TaraJensen TaraJensen changed the title Add support for setting -out argument in TCStat wrapper Add support for setting -out argument in TCStat and StatAnalysis wrappers Mar 1, 2022
@TaraJensen TaraJensen added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Mar 1, 2022
@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 1, 2022
georgemccabe added a commit that referenced this issue Mar 4, 2022
@georgemccabe
per #1102, added support for setting -out argument to tc_stat
7cdc5c1
georgemccabe added a commit that referenced this issue Mar 4, 2022
@georgemccabe
per #1102, added support for setting -out argument to stat_analysis
ea75b0f
@georgemccabe georgemccabe linked a pull request Mar 4, 2022 that will close this issue
feature 1102 -out for TCStat and StatAnalysis #1477
Merged
13 tasks
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Mar 4, 2022
georgemccabe added a commit that referenced this issue Mar 4, 2022
@georgemccabe
Per #1102, rename variable used to set the -dump_row filename to TC_S…
724534b 
…TAT_DUMP_ROW_TEMPLATE. The variable was previously called TC_STAT_OUTPUT_TEMPLATE which was not a reserved METplus config variable and was used to avoid duplicate text within the config file. However, this variable is now a reserved METplus config variable used to set the file path for the -out command line argument
georgemccabe added a commit that referenced this issue Mar 7, 2022
@georgemccabe @TaraJensen
@mrinalbiswas @bikegeek @JohnHalleyGotway @jprestop @j-opatz @CPKalb @lisagoodrich @hankenstein2
Update Develop-ref after #1102 (#1485)
55b830b 
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: TaraJensen <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: Minna Win <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: johnhg <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Co-authored-by: Mrinal Biswas <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: bikegeek <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Hank Fisher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
component: python wrapper METplus: Configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Milestone
METplus-4.1.0
Development

Successfully merging a pull request may close this issue.

feature 1102 -out for TCStat and StatAnalysis dtcenter/METplus
3 participants
@JohnHalleyGotway @TaraJensen @georgemccabe