Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #475 develop - make default configs available in package #476

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

georgemccabe
Copy link
Contributor

@georgemccabe georgemccabe commented Nov 18, 2024

Additional Changes

  • Updated the version number because develop should now include development towards the 3.1.0-beta1 release since main_v3.0 contains development towards 3.0.0.
  • Changed the docs/conf.py to read from the version file instead of duplicating the version number.
  • Added bugfix to prevent GPU error in plotly image generation when running in containers

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplotpy-3.0.0 milestone Nov 18, 2024
@georgemccabe georgemccabe linked an issue Nov 18, 2024 that may be closed by this pull request
24 tasks
@bikegeek bikegeek merged commit cd4954b into develop Nov 20, 2024
7 checks passed
@bikegeek bikegeek deleted the bugfix_475_develop_config_missing branch November 20, 2024 17:13
metplus-bot added a commit to dtcenter/METplus that referenced this pull request Nov 20, 2024
georgemccabe pushed a commit to dtcenter/METplus that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix missing config files from installed package
2 participants