Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub issue and pull request templates to reflect the current development workflow details #388

Closed
7 of 21 tasks
jprestop opened this issue Sep 14, 2023 · 0 comments · Fixed by #444 or #445
Closed
7 of 21 tasks

Update GitHub issue and pull request templates to reflect the current development workflow details #388

jprestop opened this issue Sep 14, 2023 · 0 comments · Fixed by #444 or #445
Assignees
@jprestop
Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone
METplotpy-3.0.0

Comments

@jprestop
Copy link
Contributor

jprestop commented Sep 14, 2023 •
edited
Loading

Describe the Task

Some of the details in the GitHub issue and pull request templates are out of sync with the current development workflow. Update the contents of them to make them accurate.
Use the MET issue as a guide.
Add "Add any new Python packages to the METplus Components Python Requirements table." as a question in the Pull Request Template.

Time Estimate

1 hour

Sub-Issues

Consider breaking the task down into sub-issues.
None needed

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2793521

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added type: task An actionable item of work priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team component: repository maintenance Repository maintenance issue labels Sep 14, 2023
@jprestop jprestop added this to the METplotpy-3.0.0 milestone Sep 14, 2023
@jprestop jprestop self-assigned this Sep 14, 2023
@jprestop jprestop moved this from 🆕 New to 🔖 Ready in METplus-Analysis-6.0.0 Development Sep 14, 2023
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 14, 2023
jprestop added a commit that referenced this issue May 16, 2024
@jprestop
Per #388, modified issue and pull request templates
d4b061b
jprestop added a commit that referenced this issue May 16, 2024
@jprestop
Per #388, modified issue and pull request templates
a5e7844
This was linked to pull requests May 16, 2024
Feature 388 develop update templates #443
Closed
Feature 388 main_v2.1 update templates #444
Merged
Feature 388 develop update templates #445
Merged
jprestop added a commit that referenced this issue May 16, 2024
@jprestop
Per #388, made adjustments after discusion at MET meeting
61e8760
jprestop added a commit that referenced this issue May 16, 2024
@jprestop
Per #388, made adjustments after discusion at MET meeting
8a61858
bikegeek pushed a commit that referenced this issue May 21, 2024
@jprestop
Feature 388 main_v2.1 update templates (#444)
69d41f2 
* Per #388, modified issue and pull request templates

* Per #388, made adjustments after discusion at MET meeting
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in METplus-Analysis-6.0.0 Development May 21, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Coordinated METplus-5.1 Support May 21, 2024
bikegeek added a commit that referenced this issue May 21, 2024
@jprestop @bikegeek
Feature 388 develop update templates (#445)
207276b 
* Per #388, modified issue and pull request templates

* Per #388, made adjustments after discusion at MET meeting

* Update hist.py

fix indentation

---------

Co-authored-by: bikegeek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprestop jprestop

Labels
component: repository maintenance Repository maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Coordinated METplus-5.1 Support
Status: 🏁 Done
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METplotpy-3.0.0
1 participant
@jprestop