Updates to version numbers, dates, rotation of authorship for coordin… #358
Conversation
There was a problem hiding this comment.
@bikegeek for the official release, under Update Release Notes the instructions say "When creating the official release, combine the beta release sections into one section (i.e. “Version X.Y.Z release notes (YYYYMMDD)”)." so I believe we want to combine all of the betas and rc release notes into one section for the official release so that it has the main header for the page ("METdataio Release Notes") but only one subsection ("METdataio Version 3.0.0 Release Notes (20241217)") but contains all of the dropdowns with the current information that is currently separated into subsections. Please let me know if you have any questions.
|
Thanks!
…On Tue, Dec 17, 2024 at 2:25 PM Julie Prestopnik ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@bikegeek <https://github.com/bikegeek> for the official release, under Update
Release Notes
<https://metplus.readthedocs.io/en/develop/Release_Guide/metdataio_official.html#update-release-notes>
the instructions say "When creating the official release, combine the beta
release sections into one section (i.e. “Version X.Y.Z release notes
(YYYYMMDD)”)." so I believe we want to combine all of the betas and rc
release notes into one section for the official release so that it has the
main header for the page ("METdataio Release Notes") but only one
subsection ("METdataio Version 3.0.0 Release Notes (20241217)") but
contains all of the dropdowns with the current information that is
currently separated into subsections. Please let me know if you have any
questions.
—
Reply to this email directly, view it on GitHub
<#358 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHQUHOVUX4XQOGJ3GWT2GCJDXAVCNFSM6AAAAABTZIYOPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJQGE3TENBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Thanks for making the updates to the release notes, @bikegeek. I have one more suggestion - instead of leaving the area under "New Functionality" empty, could you please add "NONE" so that users can be sure to know that we didn't add any new functionality instead of inadvertently leaving it blank? Apologies - I know this is very nit-picky... One more question - in the upgrade instructions, I noticed that there are references to files with filenames that contain references to "beta" (for example, "METdataio/METdbLoad/sql/updates/update_for_6_0_beta6.sql") and in that directory, I see that we previously had filenames like "update_for_5_1.sql". Do we want to combine the update_for_6_0_beta4.sql, update_for_6_0_beta5.sql, and update_for_6_0_beta6.sql files into one update_for_6_0.sql file? I don't fully know what these are or how they are used so I don't know what's best, but thought it was worth inquiring about.
|
Thanks Julie. We DO NOT want to consolidate the mysql files, these are
used for incrementally updating the schemas so they are not documentation
but considered code.
…On Tue, Dec 17, 2024 at 3:15 PM Julie Prestopnik ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for making the updates to the release notes, @bikegeek
<https://github.com/bikegeek>. I have one more suggestion - instead of
leaving the area under "New Functionality" empty, could you please add
"NONE" so that users can be sure to know that we didn't add any new
functionality instead of inadvertently leaving it blank? Apologies - I know
this is very nit-picky... One more question - in the upgrade instructions,
I noticed that there are references to files with filenames that contain
references to "beta" (for example,
"METdataio/METdbLoad/sql/updates/update_for_6_0_beta6.sql") and in that
directory
<https://github.com/dtcenter/METdataio/tree/main_v3.0/METdbLoad/sql/updates>,
I see that we previously had filenames like "update_for_5_1.sql
<https://github.com/dtcenter/METdataio/blob/main_v3.0/METdbLoad/sql/updates/update_for_5_1.sql>".
Do we want to combine the update_for_6_0_beta4.sql
<https://github.com/dtcenter/METdataio/blob/main_v3.0/METdbLoad/sql/updates/update_for_6_0_beta4.sql>,
update_for_6_0_beta5.sql
<https://github.com/dtcenter/METdataio/blob/main_v3.0/METdbLoad/sql/updates/update_for_6_0_beta5.sql>,
and update_for_6_0_beta6.sql
<https://github.com/dtcenter/METdataio/blob/main_v3.0/METdbLoad/sql/updates/update_for_6_0_beta6.sql>
files into one update_for_6_0.sql file? I don't fully know what these are
or how they are used so I don't know what's best, but thought it was worth
inquiring about.
—
Reply to this email directly, view it on GitHub
<#358 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4UJHTR7YNVQJ2FUIAYBL32GCO7ZAVCNFSM6AAAAABTZIYOPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJQGI3DCNZZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
@bikegeek Thanks for letting me know that we DO NOT want to consolidate the mysql files. I'm glad you know what's going on! I went ahead and added "None" under "New Functionality". I hope that is ok with you. Thank you for all of your work on these releases! I approve this PR.
|
Ugh, I just noticed it says this is a "Draft". I went ahead and approved. Let me know if you need me to re-approve. Apologies that I did not notice that sooner. |
…ated release.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases