Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 282 enhance schema #292

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Feature 282 enhance schema #292

merged 19 commits into from
Apr 8, 2024

Conversation

bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Apr 5, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

  • working with METdataio feature_282_enhance_schema branch

  • loaded the mv_mysql.sql schema into a test database on 'mohawk' (mv_load_test)

  • loaded updated ECNT data

  • ran tests in METdbLoad/sql/tests/update_schema_6.0_beta4 to verify that the database was created, the ECNT, VCNT, VL1L2, and VAL1L2 tables were created with the expected new columns.

  • Verified that only one row of result was returned for specific values of ign_conv_oerr and ign_corr_oerr in the line_data_ecnt table

  • data used is available in the METdataio/METdbLoad/tests/update_schema_6.0_beta4/Data
    (only the ECNT tarball was loaded into the database)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    in your own environment, verify that the new schema with updated data works.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ] added content to the Contributor's Guide

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Apr 5, 2024
Copy link
Contributor

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that the name of the update script is incorrect (version should be 6_0), but this otherwise looks good and seems to work.

@bikegeek
Copy link
Collaborator Author

bikegeek commented Apr 8, 2024

version number updated to 6

Copy link
Contributor

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

…rged into the develop branch and baseold has been updated
@bikegeek bikegeek merged commit d0bf16c into develop Apr 8, 2024
8 of 9 checks passed
@bikegeek bikegeek deleted the feature_282_enhance_schema branch April 8, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
2 participants