Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New columns added to the MET-11.0.0-beta1 output. Issue #92 #100

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

venitahagerty
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:
    Loaded new data, and full set of test data. All looks good with no errors.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Close #92

@TatianaBurek
Copy link
Collaborator

@JohnHalleyGotway In tables 'line_data_ctc' and 'line_data_cts' should the default value of the new 'ec_value' be 0.5 instead of -9999?

@TatianaBurek
Copy link
Collaborator

I run the test to load all data. The test finished successfully but multiple times the error:
ERROR:root:*** <class 'TypeError'> in read_data upper ***
was thrown.

@venitahagerty
Copy link
Contributor Author

Added default -9999 to speed_bar variables.

Fixed name of data file so GHA compare database test would complete successfully.

@venitahagerty venitahagerty merged commit bc517c0 into develop Aug 3, 2022
@venitahagerty venitahagerty deleted the feature_92_add_columns branch August 23, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the database schema to handle new columns added to the MET-11.0.0-beta1 output.
2 participants