-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action to run SonarQube for METcalcpy pull requests and feature branches #366
Closed
12 of 28 tasks
Closed
12 of 28 tasks
Labels
component: code optimization
Code optimization issue
priority: high
High Priority
requestor: USAF
United States Air Force
type: new feature
Make it do something new
Milestone
Comments
JohnHalleyGotway
added
priority: high
High Priority
type: new feature
Make it do something new
component: code optimization
Code optimization issue
requestor: USAF
United States Air Force
labels
Apr 3, 2024
This was referenced Apr 3, 2024
Closed
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 4, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 4, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 4, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 5, 2024
bikegeek
pushed a commit
that referenced
this issue
Apr 8, 2024
* Per #366, add SonarQube workflow for METcalcpy * Per #366, update nightly build email list. * Per #366, fix cut/paste error in the configure_sonarqube.sh script. * Per #366, just whitespace change to trigger another GHA run for the PR * Per #366, whitespace * Per #366, exclude test code from code coverage statistics.
bikegeek
pushed a commit
that referenced
this issue
Apr 8, 2024
* Per #366, add SonarQube workflow for METcalcpy * Per #366, update nightly build email list. * Per #366, fix cut/paste error in the configure_sonarqube.sh script. * Per #366, just whitespace change to trigger another GHA run for the PR * Per #366, whitespace * Per #366, exclude test code from code coverage statistics.
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 19, 2024
JohnHalleyGotway
added a commit
that referenced
this issue
Apr 19, 2024
This was
linked to
pull requests
Apr 19, 2024
bikegeek
pushed a commit
that referenced
this issue
Apr 22, 2024
bikegeek
pushed a commit
that referenced
this issue
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: code optimization
Code optimization issue
priority: high
High Priority
requestor: USAF
United States Air Force
type: new feature
Make it do something new
Describe the New Feature
This issue is to add a new SonarQube workflow to GitHub actions to automate the static code analysis for all pull requests. In addition, add a manual trigger workflow dispatch option where the reference branch can be manually specified.
Recommend adding this workflow to both the
develop
branch and the currentmain_v*
so that the workflow dispatch option can be made available.Recommend pushing results to a new SonarQube project named
METcalcpy GHA
at needham.rap.ucar.edu.Recommend having the workflow report bad status if the number of SonarQube findings are increased relative to the SonarQube reference.
See issue dtcenter/MET#2379 and its two linked PR's as an example, but the implementation for a python-only repo should be more straight-forward.
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the new feature down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Needed for the Air Force - 2771024
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
The following SonarQube issues are closely related:
New Feature Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: