Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update METbaseimage to complete the transition to the Debian 12 (bookworm) base image #12

Closed
7 of 20 tasks
JohnHalleyGotway opened this issue Aug 24, 2023 · 2 comments · Fixed by #14
Closed
7 of 20 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: build process Build process issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: new feature Make it do something new

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 24, 2023

Describe the New Feature

dtcenter/MET#2669 adds a new dependency on the Proj library (recommend using the latest Proj version 9.2.1).

This issue is to update the METbaseimage to include the proj libraries to facilitate the compilation of MET for GitHub actions. This can be accomplished as follows:

  1. Update METbaseimage to fully switch over to the Debian base image. That version is currently available on DockerHub as dtcenter/met-base:v2.0_debian. And we've been using that base image for MET development for > 6 months.
  2. Complete the transition by
  • Replacing Dockerfile with the contents of Dockerfile.debian
  • Replace Dockerfile.debian_unit_test_env with the contents of Dockerfile.unit_test_env
  • Updating the file names used in the GHA job
  1. Make sure that MET's compile_MET_all.sh script and corresponding tar file has been updated to support the compilation of Proj. Note that Enhance METbaseimage to compile the ecKit and Atlas libraries #13 will soon add support for ecKit and Atlas.
  2. Tag this repository with version 2.1 which will push a new METbaseimage version.

Including this issue on the MET-12.0.0 Development project since this change relates directly to the compilation of MET.

Acceptance Testing

Verify that the development version of MET can compile with these changes.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the new feature down into sub-issues.

Relevant Deadlines

Please do as early as possible in the MET version 12.0.0 development timeline.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@climbfuji
Copy link

Maybe you want to look into spack to build the dependencies for MET? Our spack-stack project could be very helpful in that regard.

@JohnHalleyGotway JohnHalleyGotway changed the title Update METbaseimage to include the Proj, ecKit, and Atlas libraries Update METbaseimage to complete the transition to the Debian base image Aug 25, 2023
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2023
…llowing GHA warning message: Warning: The command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2023
JohnHalleyGotway added a commit that referenced this issue Aug 25, 2023
…h script from the feature_2669_proj branch to demonstrate that this that script runs fine via GHA.
JohnHalleyGotway added a commit that referenced this issue Aug 28, 2023
@JohnHalleyGotway JohnHalleyGotway moved this to 🏗 In progress in MET-12.0.0 Development Aug 28, 2023
@JohnHalleyGotway
Copy link
Collaborator Author

Thanks @climbfuji for the info on this. I did coordinate with @jprestop about Spack. I do suspect that using Spack would be an alternative to the compile_MET_all.sh script that lives in the MET repository. The Dockerfile in this repo pulls that script and compiles the dependent libraries. So if we pursue a Spack solution, presumably we'd call that in this context rather than that compilation script.

@JohnHalleyGotway JohnHalleyGotway linked a pull request Aug 29, 2023 that will close this issue
13 tasks
JohnHalleyGotway added a commit that referenced this issue Aug 29, 2023
JohnHalleyGotway added a commit that referenced this issue Sep 5, 2023
…Dockerfile here to pull compile_MET_all.sh from develop rather than the feature_2669_proj feature branch.
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to ✅ Done in MET-12.0.0 Development Sep 5, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from ✅ Done to 🏗 In progress in MET-12.0.0 Development Sep 15, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to ✅ Done in MET-12.0.0 Development Sep 15, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Update METbaseimage to complete the transition to the Debian base image Update METbaseimage to complete the transition to the Debian 12 (bookworm) base image Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: build process Build process issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: new feature Make it do something new
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants