Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2691 main_v11.1 vx_config_tmp_files #2695

Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

These are changes to the main_v11.1 branch for inclusion in a bugfix 11.1.1 version. Note that these are the same changes as #2692, but for main_v11.1 rather than develop.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Confirm that the GHA testing workflow runs as expected and no diffs are flagged. Closely compare these file changes to those in https://github.com/dtcenter/MET/pull/2692/files. They should be identical.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    No documentation changes, but I did update the contributor's guide with details about the use of temporary files in MET for version 12.0.0.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

However, differences in PBL values derived by PB2NC may still be present, as described in #2687.

  • Please complete this pull request review by [Mon 10/2/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.1 (bugfix) milestone Sep 28, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Sep 28, 2023 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the GHA testing workflow ran as expected and no diffs were flagged. I also closely compared these file changes to those in https://github.com/dtcenter/MET/pull/2692/files and verified that they were identical. Thank you for your work on this task @JohnHalleyGotway. I approve this request.

@JohnHalleyGotway JohnHalleyGotway merged commit cb5105f into main_v11.1 Oct 2, 2023
33 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2691_main_v11.1_vx_config_tmp_files branch October 2, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Eliminate the use of temporary files in the vx_config library
2 participants