Feature #2474 sonarqube_findings_ncutil

[hsoh-u]

Expected Differences

Reducing SOnarQube findings:

• Blocker: 10 to 7
• Critical: 5 to 3 (2 new at madis2nc.cc after fixing a blocker)

src/basic/vx_math/nti.cc: avoid devide by 0
src/basic/vx_util/two_d_array.h: checs the reference is the NULL pointer
src/tools/core/stat_analysis/stat_analysis_job.cc: initialize n to 0

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Unittest and the same result

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [4/19/2023].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

HI @hsoh-u. Thank you for your work on this task. What would you like for me to do in reviewing this PR? Should I simply review the code changes or is there any testing I should be doing?

[hsoh-u]

HI @hsoh-u. Thank you for your work on this task. What would you like for me to do in reviewing this PR? Should I simply review the code changes or is there any testing I should be doing?

Yey, review the code changes. If you have a time, build and the unit test at different host (for example, HPC).

• I did manual unit test & compare the outputs with nightly build at seneca.
• No differences with GHA

[jprestop]

@hsoh-u Thank you for all of your effort on this work. It's great to see the SonarQube blocker and critical numbers reduced! I reviewed the code changes, which were pretty straightforward. Due to other tasks, I decided not to build and the unit test at different host, however because you manually ran the unit tests and compared the outputs with nightly build on seneca and because there are no differences in GitHub Actions, I am comfortable approving this pull request.