Bugfix #2482 develop time slicing yyyymmdd

[hsoh-u]

Expected Differences

The 8 digits number should be interpreted as yyyymmdd (converted to unixtime in seconds unit).

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

This command does not work because $MET_TEST_INPUT (/d1/projects/MET/MET_test_data/unit_test) is not mounted at seneca.

/d1/personal/hsoh/git/pull_request/MET_bugfix_2482_timeslicing_yyyymmdd/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/nccf/gtg/latlon/gtg_obs_forecast.20130730.i00.f00.nc plot.ps 'name="edr"; level="(20130730,0,*,*)";

Alternative test:

/d1/personal/hsoh/git/pull_request/MET_bugfix_2482_timeslicing_yyyymmdd/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test.sav/model_data/nccf/GloTEC_TEC_2015_03_17.nc tmp_test.ps 'name="TEC"; level="(20150317,,)"; file_type=NETCDF_NCCF;' -v 4

Before: "20150317" to 20150317

WARNING: MetNcCFDataFile::convert_time_to_offset() -> 20150317 does not exist at time variable

After: "20150317" to 1426550400

WARNING: MetNcCFDataFile::convert_time_to_offset() -> 1426550400 does not exist at time variable

date +%s -d "20150317" -u
1426550400

Note: $MET_TEST_INPUT (/d1/projects/MET/MET_test_data/unit_test) is not mounted at seneca.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I approve of these changes. The change to the logic makes sense, attempting to interpret as timestrings prior to interpreting as numeric indices.

I tested this in seneca:/d1/projects/MET/MET_pull_requests/met-11.1.0/met-11.1.0-beta2/bugfix_2482/MET by running:

bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/nccf/radolan_sp.nc plot.ps name="PREC"; level="(20200101,*,*)"; 

It ran as expected, as did setting that dimension to "0", "2020010100", "20200101_00", and "20200101_000000".

As expected, setting it to bad values failed:
"2": MetNcCFDataFile::convert_time_to_offset() -> 2 does not exist at time variable
"20200101_0000": VarInfoNcCF::set_magic() -> trouble parsing NetCDF dimension value "20200101_0000"!