Feature 1996 uninitialized variables

met/src/basic/vx_config/threshold.cc

@@ -1128,7 +1128,7 @@ else  {
       //  adjust PT by the requested frequency bias amount
       //
 
-      double PT_new;
+      double PT_new = 0.;
 
       if ( fbias_fcst )  {
                if ( op == thresh_le || op == thresh_lt )  PT_new = PT * fbias_val;

met/src/basic/vx_log/concat_string.cc

@@ -50,8 +50,6 @@ ConcatString::ConcatString()
 
 init_from_scratch();
 
-set_alloc_inc(default_cs_alloc_inc);
-
 }
 
 
@@ -64,8 +62,6 @@ ConcatString::ConcatString(int _alloc_inc)
 
 init_from_scratch();
 
-set_alloc_inc(_alloc_inc);
-
 }
 
 
@@ -237,23 +233,6 @@ void ConcatString::assign(const ConcatString & c)
 
    memcpy(FloatFormat, c.FloatFormat, sizeof(FloatFormat));
    Precision = c.Precision;
-   AllocInc = c.AllocInc;
-}
-
-
-////////////////////////////////////////////////////////////////////////
-
-
-void ConcatString::set_alloc_inc(int _alloc_inc)
-
-{
-
-if ( _alloc_inc < min_cs_alloc_inc )  _alloc_inc = min_cs_alloc_inc;
-
-AllocInc = _alloc_inc;
-
-return;
-
 }
 
 

met/src/basic/vx_log/concat_string.h

@@ -71,10 +71,6 @@ class ConcatString {
 
       void assign(const ConcatString &);
 
-      void extend(int);
-
-      int AllocInc;
-
       int Precision;
 
       char FloatFormat[16];
@@ -102,8 +98,6 @@ class ConcatString {
          //  set stuff
          //
 
-      void set_alloc_inc(int);
-
       void set_precision(int);
 
          //
@@ -207,8 +201,6 @@ inline int          ConcatString::precision()    const { return ( Precision ); }
 
 inline const char * ConcatString::float_format() const { return ( FloatFormat ); }
 
-inline int          ConcatString::alloc_inc()    const { return ( AllocInc ); }
-
 inline bool         ConcatString::empty()        const { return ( s ?  s->empty() : true ); }
 inline bool         ConcatString::nonempty()     const { return ( s ? !s->empty() : false ); }
 

met/src/basic/vx_log/string_array.cc

@@ -131,6 +131,7 @@ void StringArray::init_from_scratch()
 {
 
 IgnoreCase = 0;
+MaxLength = 0;
 
 clear();
 

met/src/basic/vx_log/string_array.h

@@ -37,8 +37,6 @@ class StringArray {
 
       std::vector<std::string> s;
 
-      int  Nalloc;
-
       int  MaxLength;
 
       bool IgnoreCase;

met/src/libcode/vx_nc_util/nc_utils.cc

@@ -129,6 +129,9 @@ bool get_att_value(const NcAtt *att, double &att_val) {
 int get_att_value_int(const NcAtt *att) {
    int value = bad_data_int;
    static const char *method_name = "get_att_value_int(NcAtt) -> ";
+
+   if (IS_INVALID_NC_P(att)) return value;
+
    switch (att->getType().getId()) {
       case NC_BYTE:
          ncbyte b_value;
@@ -221,15 +224,15 @@ bool get_att_value_chars(const NcAtt *att, ConcatString &value) {
 
 long long get_att_value_llong(const NcAtt *att) {
    long long value = bad_data_int;
-   att->getValues(&value);
+   if (IS_VALID_NC_P(att)) att->getValues(&value);
    return value;
 }
 
 ////////////////////////////////////////////////////////////////////////
 
 double get_att_value_double(const NcAtt *att) {
    double value = bad_data_double;
-   att->getValues(&value);
+   if (IS_VALID_NC_P(att)) att->getValues(&value);
    return value;
 }
 
@@ -1658,6 +1661,8 @@ bool get_nc_data(NcVar *var, float *data) {
                      fill_value = get_att_value_char(att_fill_value);
                   }
 
+                  var->getVar(packed_data);
+
                   if (unsigned_value) {
                      int value;
                      int positive_cnt = 0;

met/src/libcode/vx_statistics/pair_base.cc

@@ -71,6 +71,7 @@ void PairBase::clear() {
    msg_typ.clear();
    msg_typ_vals.clear();
 
+   interp_wdth = 0;
    interp_mthd = InterpMthd_None;
    interp_shape = GridTemplateFactory::GridTemplate_None;
 

met/src/libcode/vx_tc_util/vx_tc_nc_util.cc

@@ -512,6 +512,7 @@ void write_tc_azi_mean_data(NcFile* nc_out, const TcrmwGrid& grid,
     data_azi_mean = new double[grid.range_n()];
 
     for(int ir = 0; ir < grid.range_n(); ir++) {
+        data_azi_mean[ir] = 0.;
         for(int ia = 0; ia < grid.azimuth_n(); ia++) {
             int i = ir * grid.azimuth_n() + ia;
             int i_rev = (grid.range_n() - ir - 1) * grid.azimuth_n() + ia;

met/src/tools/tc_utils/tc_stat/tc_stat.cc

@@ -165,6 +165,7 @@ void process_jobs() {
    ConcatString jobstring;
    int i, n_jobs;
    TCLineCounts n;
+   const char *method_name = "process_jobs() -> ";
 
    // Open the output file
    open_out_file();
@@ -193,27 +194,29 @@ void process_jobs() {
 
       // Allocate a new job
       cur_job = factory.new_tc_stat_job(jobstring.c_str());
+      if (cur_job) {
+         // Set the job output file stream
+         cur_job->JobOut = tc_stat_out;
 
-      // Set the job output file stream
-      cur_job->JobOut = tc_stat_out;
+         // Set the output precision
+         cur_job->set_precision(conf_info.Conf.output_precision());
 
-      // Set the output precision
-      cur_job->set_precision(conf_info.Conf.output_precision());
+         // Serialize the current job
+         mlog << Debug(2)
+              << "\nProcessing Job " << i+1 << ": "
+              << cur_job->serialize() << "\n";
 
-      // Serialize the current job
-      mlog << Debug(2)
-           << "\nProcessing Job " << i+1 << ": "
-           << cur_job->serialize() << "\n";
+         // Initialize counts
+         memset(&n, 0, sizeof(TCLineCounts));
 
-      // Initialize counts
-      memset(&n, 0, sizeof(TCLineCounts));
+         // Do the job
+         cur_job->do_job(tcst_files, n);
 
-      // Do the job
-      cur_job->do_job(tcst_files, n);
-
-      mlog << Debug(2)
-           << "Job " << i+1 << " used " << n.NKeep << " out of "
-           << n.NRead << " lines read.\n";
+         mlog << Debug(2) << method_name
+              << "Job " << i+1 << " used " << n.NKeep << " out of "
+              << n.NRead << " lines read.\n";
+      }
+      else mlog << Debug(1) << method_name << "job is missing\n";
 
       mlog << Debug(3)
            << "Total lines read                 = " << n.NRead             << "\n"