Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1809 gen prob #1967

Merged
merged 28 commits into from
Nov 16, 2021
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2a159e1
Per #1809, define the ProbGenInfo class and update the Makefile to co…
JohnHalleyGotway Nov 5, 2021
8b8fc96
Per #1809, update the ProbInfoArray class to store arrays of both Pro…
JohnHalleyGotway Nov 5, 2021
661b2e7
Per #1809, since tc_pairs processes probabilities of RIRW and not gen…
JohnHalleyGotway Nov 5, 2021
79371ca
Per #1809, this is definitely a work in progress. TC-Gen parses the g…
JohnHalleyGotway Nov 5, 2021
0c52234
Per #1809, store the distance to land in the ProbInfoBase class and u…
JohnHalleyGotway Nov 5, 2021
88ec38e
Per #1809...
JohnHalleyGotway Nov 5, 2021
78c930a
Per #1809, work in progress renaming tc_gen functions in a more consi…
JohnHalleyGotway Nov 9, 2021
9929924
Per #1809, make the genesis probability thresholds configurable.
JohnHalleyGotway Nov 9, 2021
475c96a
Per #1809, add ProbInfoArray::n_technique() member function to count …
JohnHalleyGotway Nov 11, 2021
c52c899
Per #1809, update PCTInfo to add the set_fthresh() function and expan…
JohnHalleyGotway Nov 11, 2021
ca8506c
Per #1809, update TC-Gen to add options for probabilistic outputs whe…
JohnHalleyGotway Nov 11, 2021
5236918
Per #1809, switch to consistently naming classes related to the proba…
JohnHalleyGotway Nov 11, 2021
aa858f3
Per #1809, saving off the current state of development before proceed…
JohnHalleyGotway Nov 12, 2021
4141adb
Per #1809, keep track of the min/max BEST track genesis times, and we…
JohnHalleyGotway Nov 12, 2021
3b0a2df
Per #1809, make access to ProbGenInfoArray elements non-constant so t…
JohnHalleyGotway Nov 12, 2021
42d6fad
Per #1809, Update the ProbGenInfo class to store a pointer to the mat…
JohnHalleyGotway Nov 12, 2021
5c2575e
Per #1809, this is a good stopping point. I have tc-gen accurately ve…
JohnHalleyGotway Nov 12, 2021
bfbf570
Per #1809, have to link to vx_nav to call gc_dist().
JohnHalleyGotway Nov 12, 2021
d9f4382
Per #1809, add PROB_LEAD and PROB_VAL to the GENMPR line type.
JohnHalleyGotway Nov 13, 2021
17b1323
Per #1809, add PROB_LEAD and PROB_VAL to the GENMPR line type.
JohnHalleyGotway Nov 13, 2021
9f834d1
Per #1809, add GenesisLead to the ProbGenInfo class to track the lead…
JohnHalleyGotway Nov 13, 2021
9a722e1
Per #1809, update tc_gen to write PROB_GENESIS matched pair output to…
JohnHalleyGotway Nov 13, 2021
b9dd9f0
Per #1809, stop storing a pointer to the BEST genesis info object in …
JohnHalleyGotway Nov 13, 2021
ac1045c
Per #1809, use ProbGenPCTInfo to store pointers to the individual mat…
JohnHalleyGotway Nov 13, 2021
540a4f4
Per #1809, add a call to tc_gen in unit_tc_gen.xml.
JohnHalleyGotway Nov 13, 2021
effa629
Per #1809, update the tc_gen chapter of the user's guide.
JohnHalleyGotway Nov 15, 2021
7bc3d70
Per #1809, fix typo in docs.
JohnHalleyGotway Nov 15, 2021
a18b069
Per #1809, doc updates.
JohnHalleyGotway Nov 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Per #1809, make the genesis probability thresholds configurable.
JohnHalleyGotway committed Nov 9, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9929924bb60f06dd34d0a374be8a3636598d8d59
5 changes: 5 additions & 0 deletions met/data/config/TCGenConfig_default
Original file line number Diff line number Diff line change
@@ -212,6 +212,11 @@ ops_method_flag = TRUE;
//
////////////////////////////////////////////////////////////////////////////////

//
// Genesis probability thresholds
//
genesis_prob_thresh = ==0.25;

//
// Confidence interval alpha value
//
1 change: 1 addition & 0 deletions met/src/basic/vx_config/config_constants.h
Original file line number Diff line number Diff line change
@@ -1097,6 +1097,7 @@ static const char conf_key_ops_hit_window[] = "ops_hit_window";
static const char conf_key_discard_init_post_genesis_flag[] = "discard_init_post_genesis_flag";
static const char conf_key_dev_method_flag[] = "dev_method_flag";
static const char conf_key_ops_method_flag[] = "ops_method_flag";
static const char conf_key_genesis_prob_thresh[] = "genesis_prob_thresh";
static const char conf_key_fcst_fy_oy[] = "fcst_fy_oy";
static const char conf_key_fcst_fy_on[] = "fcst_fy_on";
static const char conf_key_fcst_tracks[] = "fcst_tracks";
21 changes: 8 additions & 13 deletions met/src/tools/tc_utils/tc_gen/tc_gen_conf_info.cc
Original file line number Diff line number Diff line change
@@ -164,6 +164,7 @@ void TCGenVxOpt::clear() {
OpsHitBeg = OpsHitEnd = bad_data_int;
DiscardFlag = false;
DevFlag = OpsFlag = false;
GenProbThresh.clear();
CIAlpha = bad_data_double;
OutputMap.clear();
NcInfo.clear();
@@ -288,7 +289,10 @@ void TCGenVxOpt::process_config(Dictionary &dict) {
<< " must be set to true!\n\n";
exit(1);
}


// Conf: genesis_prob_thresh
GenProbThresh = dict.lookup_thresh_array(conf_key_genesis_prob_thresh);

// Conf: ci_alpha
CIAlpha = dict.lookup_double(conf_key_ci_alpha);

@@ -531,18 +535,10 @@ bool TCGenVxOpt::is_keeper(const ProbGenInfo &gi) const {
if(InitHour.n() > 0 && !InitHour.has(gi.init_hour()))
keep = false;

// Lead times: JHG, gi has up to 3 lead times!?
/*
if(Lead.n() > 0 && !Lead.has(gi.lead()))
keep = false;
*/
// Lead and valid times:
// ProbGenInfo objects can contain multiple lead/valid times.
// Do not filter by them here.

// Valid time window: JHG, gi has 3 valid times!?
/*
if((ValidBeg > 0 && ValidBeg > gi.valid_min()) ||
(ValidEnd > 0 && ValidEnd < gi.valid_max()))
keep = false;
*/
// Poly masking
if(VxPolyMask.n_points() > 0 &&
!VxPolyMask.latlon_is_inside(gi.lat(), gi.lon()))
@@ -570,7 +566,6 @@ bool TCGenVxOpt::is_keeper(const ProbGenInfo &gi) const {
return(keep);
}


////////////////////////////////////////////////////////////////////////

STATOutputType TCGenVxOpt::output_map(STATLineType t) const {
1 change: 1 addition & 0 deletions met/src/tools/tc_utils/tc_gen/tc_gen_conf_info.h
Original file line number Diff line number Diff line change
@@ -145,6 +145,7 @@ class TCGenVxOpt {
bool DiscardFlag, DevFlag, OpsFlag;

// Output file options
ThreshArray GenProbThresh;
double CIAlpha;
map<STATLineType,STATOutputType> OutputMap;
TCGenNcOutInfo NcInfo;