Feature 1936 madis nc

[hsoh-u]

Pull Request Testing

• Describe testing already performed for these changes:
  

  • Tested with 2017 & 2021 mesonet data
  • set MET_BASE for the updated default configuration file

export MET_BASE=/d1/personal/hsoh/git/features/feature_1936_madis_nc/MET/met/share/met
/d1/personal/hsoh/git/features/feature_1936_madis_nc/MET/met/bin/madis2nc /d1/projects/MET/MET_test_data/unit_test/obs_data/madis/mesonet/mesonet_20170101_0000.nc out_mesonet_20170101_0000.nc -type mesonet

/d1/personal/hsoh/git/features/feature_1936_madis_nc/MET/met/bin/madis2nc /d1/personal/hsoh/data/MET-1936/20210101_0000 out_mesonet_20210101_0000.nc -type mesonet

unit test : unit_madis2nc.xml

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Review document at 6.3.2. madis2nc configuration file.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Added mesonet_opt_var at 6.3.2. madis2nc configuration file.

• Do these changes include sufficient testing updates? [Yes]

A unit test, madis2nc_MESONET_optional_vars, is added

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  

One more output: mesonet_20170101_0000_F000.nc

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

Suggested change

	mesonet_opt_var = [ "precip3hr", "precip6hr", "precip12hr", "precip10min" ];
	mesonet_opt_var = [ "precip3hr", "precip6hr", "precip12hr", "precip10min" ];

[JohnHalleyGotway]

@hsoh-u so what are we going to do about this PR? Is there a way of supporting multiple versions of these input files without needing to add a new config file option? It'd be preferable to only add new config options when really needed. Hopefully there's a solution that doesn't require users to be aware of the specific details of the contents of the input files.

If needed, we could shift this issue and PR to the beta5 development cycle instead.

[JohnHalleyGotway]

@hsoh-u is this pull request superceded by #1984?

If so, I recommend that you close it without merging.

[hsoh-u]

The default configuration will not be updated for this. Superseded by #1984