Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix_1906_main_v10.0_tmp_filenames #1953

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Changes are described in the Pull Request for the develop branch and are the same:
#1952

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the files changed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [11/02/21].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…tead of only the filename so that the function can tell whether or not the file exists.
@jprestop jprestop added this to the met-10.0.1 (bugfix) milestone Oct 26, 2021
@jprestop jprestop linked an issue Oct 26, 2021 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

These are the same changes made for the develop branch and discussed in this PR review comment.

@jprestop jprestop merged commit 64b445a into main_v10.0 Oct 26, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_1906_main_v10.0_tmp_filenames branch March 17, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug with the incrementing of numbers in temporary file names
2 participants