Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1945 L0 #1946

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Feature 1945 L0 #1946

merged 2 commits into from
Oct 20, 2021

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Oct 19, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

    None. I made the simple change and note that the NB output should remain unchanged. So I'm leveraging that automated testing instead of spending time testing manually.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please just review the modified files.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

    I checked and the user's guide makes no mention of L0 vs Z0 for GO Index. No changes are needed.

  • Do these changes include sufficient testing updates? [Yes]

    No additional testing is needed. The existing GO Index and SS Index jobs should both run and produce exactly the same output as before.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Wednesday 8/20/21].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Oct 19, 2021
@JohnHalleyGotway JohnHalleyGotway linked an issue Oct 19, 2021 that may be closed by this pull request
20 tasks
Copy link

@michelleharrold michelleharrold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnHalleyGotway - I visually inspected the change from Z0 --> L0, and it looks good to me.

@JohnHalleyGotway JohnHalleyGotway merged commit 16edb89 into develop Oct 20, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1945_L0 branch October 20, 2021 03:06
@JohnHalleyGotway JohnHalleyGotway restored the feature_1945_L0 branch October 20, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the STAT-Analysis GO Index configuration file.
2 participants