Feature 1921 warnings

[JohnHalleyGotway]

Pull Request Testing

• Describe testing already performed for these changes:
  
  Lots of small changes here in an attempt to reduce the number of warnings MET prints out. While the largest categories of warnings have been investigated, not all of them have been. Since this is a relatively low priority task, recommend that we proceed with the current set of changes instead of waiting for every single one to be investigated.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Review code changes. Inspect regression test output to confirm that the only diffs are the expected change to Grid-Diag:
/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta3/feature_1921/test_regression.log
(see below)

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

None needed.

• Do these changes include sufficient testing updates? [Yes]

No additional testing required to reduce warning messages. Did modify a Grid-Diag unit test to improve it rather than running it on a mixed set of APCP accumulation intervals.

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Changes the output of the Grid-Diag unit test, switching from running on a mixed set of APCP accumulation intervals to RH instead:
  test_output/grid_diag/grid_diag_out.nc

COMPARING grid_diag/grid_diag_out.nc
file1: MET-feature_1921_warnings/test_output/grid_diag/grid_diag_out.nc
file2: MET-develop/test_output/grid_diag/grid_diag_out.nc
ERROR: NetCDF headers differ:
3,4c3,4
< 	RH_Z2 = 100 ;
< 	PWAT_L0 = 80 ;
---
> 	APCP_00_L0 = 55 ;
> 	PWAT_L0 = 35 ;

• Please complete this pull request review by [Wednesday 10/6/2021].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I reviewed the code changes and inspected the regression test output, confirming that the only diffs are the expected changes to Grid-Diag. I approve this request.

Waiting for the rerun of the commands to regenerate the warning list before approving.

[JohnHalleyGotway]

@jprestop please proceed with this PR review. The total number of non-empty warning lines produced by the unit test commands have been reduced from 1127 to 227. In addition, the changes for "ipdtmpl" warnings lower that number even further.

grep WARNING unit_test_cmds_OLD.log | egrep "[a-z]" | wc -l
    1127
johnhg$ grep WARNING unit_test_cmds_NEW.log | egrep "[a-z]" | wc -l
     227

Please see this issue comment for the details.

[jprestop]

Wow! Those are significant changes! I will approve this PR again now.