Bugfix 1395 main_v10.0 comp script #1796
Conversation
There was a problem hiding this comment.
Julie, I skimmed these changes and see that they're all confined to the installation script area. And I assume the updates reflect how you installed MET version 10.0.0, which is great.
And I see that there's a separate PR to updated the develop branch. I'm renaming the title of this PR to indicate that it's for the main_v10.0 branch. When making bugfixes to both the main_v10.0 and develop branches, please name the branches like this:
bugfix_NNNN_main_v10.0_DESC
bugfix_NNNN_develop_DESC
I approve of these changes.
JohnHalleyGotway
changed the title
|
Yes, the updates reflect how I installed MET version 10.0.0, with corrections made based on the installations. Thanks for renaming the title of this PR to indicate that it's for the main_v10.0 branch. I appreciate that. My apologies for the incorrect naming. I will follow that format in the future. |
* Per #1789, remove duplicate plot_point_obs configuration section. (#1790) * Per #1798, fix up the read_tmpe_dataplane.py script to handle a grid string or dictionary. (#1799) * Github Issue #1801: Comment out code that checks for BEST track to support extra-tropical cyclone tracks not verified against BEST tracks. * Bugfix 1395 main_v10.0 comp script (#1796) * Updating compile script and associated config files for met-10.0.0 * Removing old config files * install_met_env.het * Updated orion file * Added stampede2 config file * Adding modulefiles for various machines * Feature main_v10.0 bugfix_checklist (#1803) * Recommended updates to clarify the use of projects and milestones for bugfixes. * Making details consistent across all issue templates. * Per met-help question (https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=99964) clarify the description of the obs_thresh option. * Update README.md Adding text for GitHub Discussions * changed non-unicode apostrophe and fixed typo in URL (#1813) * Correct formatting errors in release notes. * #1817 Added to_north argument at two_to_one() * #1817 Calls two_to_one() with false for the third argument, if latitude moves north to south * #1508 checking stat() methoid returns no error before looking at FILE flag Co-authored-by: bikegeek <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: bikegeek <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: hsoh-u <[email protected]>
Pull Request Testing
Describe testing already performed for these changes:
Installed met-10.0.0 using this script and associated config files on various machines.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
There is really nothing to test. Review the files changed, if desired.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [None needed]
Do these changes include sufficient testing updates? [None needed]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [5/26/21].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone