-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 1395 comp script #1605
Merged
Merged
Task 1395 comp script #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in configuration of MET to remove --enable-modis and --enable-lidar2nc if those libraries aren't built. Need to handle this smarter because even if they're not compiled, they may be installed already...
…e ability for user specify what compilers to use and some additional linking flags for HDF5.
…the configuration for surge
19 tasks
JohnHalleyGotway
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not actually test any of these changes, but see that they're confined to the installation script. So they won't break the compiled code. I did briefly review the changes and did not see any obvious problems. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Installed MET using the script and associated config files on various machines
Recommend testing for the reviewer to perform, including the location of input datasets:
None
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
After merging, should the reviewer DELETE the feature branch from GitHub? [NO]
Please do NOT delete this branch. I have more improvements to make but wanted to get these important updates into develop sooner rather than later.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone