Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 1395 comp script #1605

Merged
merged 10 commits into from
Dec 10, 2020
Merged

Task 1395 comp script #1605

merged 10 commits into from
Dec 10, 2020

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Installed MET using the script and associated config files on various machines

  • Recommend testing for the reviewer to perform, including the location of input datasets:

    None

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • After merging, should the reviewer DELETE the feature branch from GitHub? [NO]

    Please do NOT delete this branch. I have more improvements to make but wanted to get these important updates into develop sooner rather than later.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.

@jprestop jprestop added this to the MET 10.0.0 milestone Dec 10, 2020
@jprestop jprestop linked an issue Dec 10, 2020 that may be closed by this pull request
19 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not actually test any of these changes, but see that they're confined to the installation script. So they won't break the compiled code. I did briefly review the changes and did not see any obvious problems. Looks good!

@JohnHalleyGotway JohnHalleyGotway merged commit 3429ca9 into develop Dec 10, 2020
@jprestop jprestop deleted the task_1395_comp_script branch May 12, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the MET compilation script and its documentation
2 participants