Bugfix 1508 develop tc_gen #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enames, abort, assuming that this is not actually a file list!
21 tasks
georgemccabe
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
I ran the tests from PR #1524 and verified that the changes fixed the issue. These code changes are the same as the 3.1 PR, so I approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Please see pull request #1524 for details. This is the exact same code change, but merging into develop instead of main_v9.1.
Compile PR code in kiowa:/d1/projects/MET/MET_pull_requests/met-10.0_beta1/bugfix_1508/MET-bugfix_1508_develop_tc_gen_into_develop/met.
Ran unit tests and wrote log output to kiowa:/d1/projects/MET/MET_pull_requests/met-10.0_beta1/bugfix_1508/unit_test_bugfix_1508_develop.log
Recommend reviewing PR #1524 and this one at the same time.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone