Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect intensity_flag variable naming in the MODE documentation. #2603

Closed
21 tasks
davidalbo opened this issue Jul 6, 2023 · 1 comment · Fixed by #2604
Closed
21 tasks

Fix incorrect intensity_flag variable naming in the MODE documentation. #2603

davidalbo opened this issue Jul 6, 2023 · 1 comment · Fixed by #2604
Assignees
Labels
type: task An actionable item of work
Milestone

Comments

@davidalbo
Copy link
Contributor

Replace italics below with details for this issue.

Describe the Task

The MODE documentation describes a variable as multivar_intensity, it should be multivar_intensity_flag.

Time Estimate

Estimate the amount of work required here.
several hours.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

July 10, 2023

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@davidalbo davidalbo added type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jul 6, 2023
@davidalbo davidalbo added this to the MET 11.1.0 milestone Jul 6, 2023
hertneky added a commit that referenced this issue Jul 6, 2023
Update mode.rst to modify multivar_intensity to multivar_intensity_flag
#2603
davidalbo pushed a commit that referenced this issue Jul 7, 2023
Update mode.rst to modify multivar_intensity to multivar_intensity_flag
#2603
@davidalbo davidalbo linked a pull request Jul 7, 2023 that will close this issue
15 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in MET-11.1.0 Development Jul 7, 2023
@georgemccabe
Copy link
Collaborator

This fix was also applied to the develop branch with commit 10b1480.

@JohnHalleyGotway JohnHalleyGotway removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An actionable item of work
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants