-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Correct definitions of NCEP grid numbers 172 and 220 #2399
Closed
8 of 20 tasks
Labels
MET: Library Code
priority: high
High Priority
reporting: DTC NCAR Base
NCAR Base DTC Project
reporting: DTC NOAA BASE
NOAA Office of Atmospheric Research DTC Project
requestor: NOAA/EMC
NOAA Environmental Modeling Center
type: bug
Fix something that is not working
Milestone
Comments
JohnHalleyGotway
added
requestor: NOAA/EMC
NOAA Environmental Modeling Center
type: task
An actionable item of work
alert: NEED ACCOUNT KEY
Need to assign an account key to this issue
required: FOR OFFICIAL RELEASE
Required to be completed in the official release for the assigned milestone
MET: Library Code
priority: high
High Priority
labels
Jan 12, 2023
JohnHalleyGotway
changed the title
Update definitions of NCEP grid numbers 172 and 220
Bugfix: Correct definitions of NCEP grid numbers 172 and 220
Jan 12, 2023
github-project-automation
bot
moved this to 📋 Backlog
in Coordinated METplus-5.0 Support
Jan 12, 2023
JohnHalleyGotway
moved this from 📋 Backlog
to 🔖 Ready
in Coordinated METplus-5.0 Support
Jan 12, 2023
JohnHalleyGotway
added
type: bug
Fix something that is not working
and removed
type: task
An actionable item of work
required: FOR OFFICIAL RELEASE
Required to be completed in the official release for the assigned milestone
labels
Jan 12, 2023
JohnHalleyGotway
moved this from 🔖 Ready
to 🏗 In progress
in Coordinated METplus-5.0 Support
Jan 12, 2023
These commands demonstrate the problem in MET:
Rerunning the commands above after updating the grid definitions based on comments in NOAA-EMC/NCEPLIBS-w3emc#157 fixes the problem, as seen here: |
JohnHalleyGotway
added a commit
that referenced
this issue
Jan 12, 2023
JohnHalleyGotway
added a commit
that referenced
this issue
Jan 12, 2023
15 tasks
This was
linked to
pull requests
Jan 12, 2023
@JohnHalleyGotway These look great! Ahhh what a relief to see them correct! |
JohnHalleyGotway
added a commit
that referenced
this issue
Jan 15, 2023
JohnHalleyGotway
added a commit
that referenced
this issue
Jan 15, 2023
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in MET-11.1.0 Development
Jan 15, 2023
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Coordinated METplus-5.0 Support
Jan 15, 2023
TaraJensen
added
reporting: DTC NCAR Base
NCAR Base DTC Project
reporting: DTC NOAA BASE
NOAA Office of Atmospheric Research DTC Project
labels
Jan 25, 2023
JohnHalleyGotway
removed
the
alert: NEED ACCOUNT KEY
Need to assign an account key to this issue
label
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MET: Library Code
priority: high
High Priority
reporting: DTC NCAR Base
NCAR Base DTC Project
reporting: DTC NOAA BASE
NOAA Office of Atmospheric Research DTC Project
requestor: NOAA/EMC
NOAA Environmental Modeling Center
type: bug
Fix something that is not working
Describe the Task
Issue NOAA-EMC/NCEPLIBS-w3emc#157 corrects the definition of NCEP Grid 172 and 220.
Once that issue has been fixed, those changes should be migrated to the MET library code. Specifically, look in src/libcode/vx_grid/find_grid_by_name.h at:
Those are the lines that will eventually change.
Time Estimate
2 hours
Sub-Issues
Consider breaking the task down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
Task Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: