Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct definitions of NCEP grid numbers 172 and 220 #2399

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Jan 12, 2023 · 2 comments · Fixed by #2405 or #2406
Closed
8 of 20 tasks

Bugfix: Correct definitions of NCEP grid numbers 172 and 220 #2399

JohnHalleyGotway opened this issue Jan 12, 2023 · 2 comments · Fixed by #2405 or #2406
Assignees
Labels
MET: Library Code priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jan 12, 2023

Describe the Task

Issue NOAA-EMC/NCEPLIBS-w3emc#157 corrects the definition of NCEP Grid 172 and 220.

Once that issue has been fixed, those changes should be migrated to the MET library code. Specifically, look in src/libcode/vx_grid/find_grid_by_name.h at:

   { "G172", 'S', -60.0, -36.866, -139.806, 0.0,  0.0, -100.0,  12.7,   ncep_earth_radius_km,  690,  710 },
   { "G220", 'S', -60.0, -36.866, -139.806, 0.0,  0.0, -100.0,  25.4,   ncep_earth_radius_km,  345,  355 },

Those are the lines that will eventually change.

Time Estimate

2 hours

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: Library Code priority: high High Priority labels Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Update definitions of NCEP grid numbers 172 and 220 Bugfix: Correct definitions of NCEP grid numbers 172 and 220 Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in Coordinated METplus-5.0 Support Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working and removed type: task An actionable item of work required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🏗 In progress in MET-11.1.0 Development Jan 12, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🏗 In progress in Coordinated METplus-5.0 Support Jan 12, 2023
@JohnHalleyGotway
Copy link
Collaborator Author

These commands demonstrate the problem in MET:

for GRID in `echo "G172 G220"`; do
   bin/regrid_data_plane GFS.grb2 ${GRID} ${GRID}.nc -field 'name="LAND";level="Z0";'
   bin/plot_data_plane ${GRID}.nc ${GRID}.ps 'name="LAND_Z0"; level="(*,*)";'
done

Screen Shot 2023-01-12 at 4 24 41 PM

Rerunning the commands above after updating the grid definitions based on comments in NOAA-EMC/NCEPLIBS-w3emc#157 fixes the problem, as seen here:
Screen Shot 2023-01-12 at 4 28 11 PM

@malloryprow
Copy link

@JohnHalleyGotway These look great! Ahhh what a relief to see them correct!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Jan 15, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Coordinated METplus-5.0 Support Jan 15, 2023
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Jan 25, 2023
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Library Code priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants