Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the python list to the numpy array for the python embedding at the base class. #2386

Closed
21 tasks
hsoh-u opened this issue Dec 21, 2022 · 2 comments · Fixed by #2443 or #2462
Closed
21 tasks
Assignees
Labels
component: CI/CD Continuous integration and deployment issues MET: PreProcessing Tools (Point) priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Dec 21, 2022

The python list and the numpy array are accepted for the python embedding. The current implementation gives a INFO message if the python list contains numpy data type members.

  • no info message with 1) python list & python general numeric data type members and 2) numpy array & numpy data type members
  • info message with the python list & the numpy data type members
==INFO_PYTHON== Recommend using numpy instead of python list for obs_hgt (<class 'numpy.float32'>)
==INFO_PYTHON== Recommend using numpy instead of python list for obs_val (<class 'numpy.float32'>)

Describe the Enhancement

MET codes handle better with the numpy array than the python list for the python embedding. It's better to convert the python list to numpy array instead of giving a INFO message at the base python class (met_point_obs.py).

Time Estimate

Estimate the amount of work required here.
4 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.
2702691

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@hsoh-u hsoh-u added type: enhancement Improve something that it is currently doing priority: medium Medium Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team MET: PreProcessing Tools (Point) labels Dec 21, 2022
@hsoh-u hsoh-u self-assigned this Dec 21, 2022
@hsoh-u hsoh-u changed the title Cnvert the python list to the numpy array for the python embedding at rhe base class. Convert the python list to the numpy array for the python embedding at the base class. Dec 21, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Dec 22, 2022
@JohnHalleyGotway JohnHalleyGotway moved this to 📋 Backlog in MET-11.1.0 Development Dec 22, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Dec 22, 2022
@hsoh-u hsoh-u removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 7, 2023
@hsoh-u hsoh-u moved this from 🔖 Ready to 🏗 In progress in MET-11.1.0 Development Feb 7, 2023
hsoh-u pushed a commit that referenced this issue Feb 15, 2023
@hsoh-u hsoh-u linked a pull request Feb 15, 2023 that will close this issue
15 tasks
@DanielAdriaansen
Copy link
Contributor

@hsoh-u was this required for #2443 or was this fixed in #2443 because you were in the code and easy to do at the same time?

@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Feb 18, 2023

@hsoh-u was this required for #2443 or was this fixed in #2443 because you were in the code and easy to do at the same time?

It was to do at the same time instead of creating tqo pull requests

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Feb 20, 2023
@hsoh-u hsoh-u linked a pull request Feb 23, 2023 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CI/CD Continuous integration and deployment issues MET: PreProcessing Tools (Point) priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
No open projects
Status: Done
3 participants