Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensemble post-processing from the Ensemble-Stat tool. #1908

Closed
21 tasks done
JohnHalleyGotway opened this issue Sep 2, 2021 · 1 comment · Fixed by #2265
Closed
21 tasks done

Remove ensemble post-processing from the Ensemble-Stat tool. #1908

JohnHalleyGotway opened this issue Sep 2, 2021 · 1 comment · Fixed by #2265
Assignees
Labels
MET: Ensemble Verification priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: DTC/SRW DTC Short Range Weather T&E requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 2, 2021

Describe the Enhancement

MET#1904 added a new Gen-Ens-Prod ensemble post-processing tool to MET version 10.1.0, and MET#1907 warned users that ensemble product generation would be removed from Ensemble-Stat in a future version. This issue is to strip the processing of the "ens" dictionary, along with ensemble product generation options out of the Ensemble-Stat tool.

Need to more carefully define which, if any, of the "ensemble_flag" options should remain. For example, depending on the "output_flag" options requested, Ensemble-Stat will still need to compute the ensemble mean, standard deviation, and gridded ranks. Should it retain the ability to write those fields to an output NetCDF file?

Propose REMOVING minus, plus, min, max, range, frequency, nep, and nmep, leaving the following options which remain:

ensemble_flag = {
   latlon    = TRUE;
   mean      = TRUE;
   stdev     = TRUE;
   vld_count = TRUE;
   rank      = TRUE;
   weight    = TRUE;
}

Recommend that the tool check to see if the user provides and "ens" dictionary in the configuration file, and if so, error out with a useful error message. Also be sure to update the MET flowchart changing Ensemble-Stat from being green and blue, to only blue. It is a statistics generation tool (blue) but no longer does pre-processing (green).

Recommend coordinating these changes with @michelleharrold and the DTC UFS/SRW team.

Note that this work should be done in conjunction with #2139.

Time Estimate

2 days.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

2793541

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: high requestor: UK Met Office United Kingdom Met Office alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: Ensemble Verification labels Sep 2, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 2, 2021
@JohnHalleyGotway JohnHalleyGotway self-assigned this Sep 2, 2021
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Feb 8, 2022
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Apr 15, 2022
@JohnHalleyGotway JohnHalleyGotway added the requestor: DTC/SRW DTC Short Range Weather T&E label Apr 15, 2022
@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority and removed priority: high labels May 9, 2022
JohnHalleyGotway added a commit that referenced this issue Sep 8, 2022
…t use ens_file_list and ens_file_vld instead.
JohnHalleyGotway added a commit that referenced this issue Sep 8, 2022
JohnHalleyGotway added a commit that referenced this issue Sep 18, 2022
JohnHalleyGotway added a commit that referenced this issue Sep 18, 2022
… compiles and runs, but I still need to do more testing and refinement.
JohnHalleyGotway added a commit that referenced this issue Sep 18, 2022
…Move vld_thresh and ens_thresh into the fcst dictionary.
JohnHalleyGotway added a commit that referenced this issue Sep 19, 2022
JohnHalleyGotway added a commit that referenced this issue Sep 19, 2022
…ing the config options related to ensemble post-processing.
JohnHalleyGotway added a commit that referenced this issue Sep 19, 2022
…when we tack the control file to the end of the list of ensemble files, we also increment the n_ens_files counter.
JohnHalleyGotway added a commit that referenced this issue Sep 19, 2022
…nsemble_stat_SINGLE_FILE_NC_WITH_CTRL run. When all members are read from the same input file, DO NOT append the control file to the of the ensemble file list.
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 19, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 19, 2022 that will close this issue
15 tasks
@JohnHalleyGotway
Copy link
Collaborator Author

Recommend renaming ensemble_flag to something else. Perhaps ens_rank_flag, ensemble_pairs_flag, or obs_rank_flag? This is similar in functionality to nc_pairs_flag in Grid-Stat.

JohnHalleyGotway added a commit to dtcenter/METplus that referenced this issue Sep 19, 2022
…using the MET tag test_feature_1908 from the feature_1908_remove_ens branch. The question is whether or not the removal of ensemble post-processing breaks the EnsembleStat Wrapper. If all the use cases run without error, then that's a success and we should include dtcenter/MET#1908 in beta3. If they do not, consider shifting that to beta4 instead.
JohnHalleyGotway added a commit that referenced this issue Sep 19, 2022
…_flag to nc_orank_flag and update its contents. Also make it configurable separetly for each vx task. Also update the User's Guide with this info.
JohnHalleyGotway added a commit that referenced this issue Sep 20, 2022
…stat runs. Needed to add 3 that are now being created.
JohnHalleyGotway added a commit that referenced this issue Sep 20, 2022
…compute normal ci's when the forecast, observation, and error standard deviations are bad data.
JohnHalleyGotway added a commit that referenced this issue Sep 20, 2022
…ta as bad_data_double (-9999) instead of -999.
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Sep 21, 2022
Repository owner moved this from To Do to Done in MET-11.0.0-beta3 (9/21/22) Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Ensemble Verification priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: DTC/SRW DTC Short Range Weather T&E requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants