-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Lambert Azimuthal Equal Area grids #1693
Comments
From @michelleharrold: The deliverable for this project is due 31 May, so the sooner the better! For reference - the EUMETNET data is what this is needed for. It is currently in HDF5, so the goal is to have you write the python code to convert to MET-friendly NetCDF and then have MET be able to handle the lambert azimuthal equal area grid. I suppose we could also have you include a regridding in the python script to bypass needing the lambert azimuthal equal area grid...but that seems like a cop out? But there is a hard deadline of 31 May -- and that is when the analysis needs to be done, so we need about 2 weeks to actually run MET and analyze output. Is this reasonable? |
From @rgbullock I finished up the laea grid code. I've also tested it and it seems to be working well. I decided to go with the series expansion rather than the iterative scheme in the code, because it turns out that the iteration doesn't always converge. The definition for the grid Michelle and Tracy are using is contained in the source file "laea_grid_defs.h". It's currently called tracy_data ... you'll probably want to change the name to something else. For the benefit of those who will ultimately have the task of maintaining my grid code, the main reference for this work is "Map Projections --- A Working Manual", by John P. Snyder I'll let someone else write the code for wiring this up to the 2D data factory class. It should just be a matter of populating the LaeaData struct from the info in the data file. I guess that's it unless there's something I've forgotten about. One thing: Since this grid is on a non-spherical earth, any code that uses it will need to link to libvx_geodesy.a when compiling, so someone should probably add that to any of the Makefile.am files where it's needed so that autoconf knows about it. |
@rgbullock has finished development for this support. Added @JohnHalleyGotway to the assignee list so he can work on integrating these changes into the rest of the MET codebase. |
…. The only real change here is defining LaeaGrid::serialize().
Here is a link to the GRIB2 definition of Lambert Azimuthal Equal Area grids: Along with an ECMWF grid template: And here is a sample LAEA GRIB2 file I found on the MetOffice website:
@rgbullock, how can we translate these GRIB2 projection definitions to the entries in the LaeaData struct that you've already added? |
… as currently implemented. Since they rely on the vx_geodesy library, I also updated all the Makefile.am files by adding -lvx_geodesy immediately after each -lvx_grid entry.
…d in main_v10.0 and develop. Setting grid = name does not work when MET_PYTHON_EXE is set. The read_tmp_dataplane.py needs to be tweaked to support this usage.
@rgbullock can you please provide an update on this issue? Are you able to update the MET library code to instantiate a LAEA grid from a GRIB2 file? |
Thanks @robdarvell, I just grabbed those files but did not find what I expected:
Looks like this is for a Transverse Mercator projection rather than Lambert Azimuthal Equal Area. Do you have any sample data for the latter that I can use to develop/test this issue? |
Apologies @JohnHalleyGotway for the duff data. I was told the radar files were on the LAEA grid, but I hadn't actually checked through the ncdump before I sent them. I have placed a new temperature and visibility file onto the ftp server, and checked that the ncdump talked about LAEA on them. Hopefully (!) they are what you need. Rob |
…ize a grid using LAEAGrib2Data but just can't get the survive to the output step. The lg pointer is set initially but it gets reset to la.
Trying to get this going again. @JohnHalleyGotway - did we ever grab the files @robdarvell put up on the FTP server? If not - hopefully @robdarvell can post them again. |
I have put some alternate LAEA grid files on the ftp server in darvell_data |
…ted PostScript output file name so that the test will pass. Also update the config.tab.cc and color_parser_yacc.cc with the current NULLPTR contents that are created on seneca. Hopefully that'll solve the EmptyConfigFile GHA failure.
…t this support should be restored prior to the MET-11.1.0 release.
Co-authored-by: rgbullock <[email protected]> Co-authored-by: Randy Bullock <[email protected]>
Describe the New Feature
As of 10/25/22 - Identified as CRITICAL for Met Office:
MET assumes a spherical Earth. The EUMETNET (radar) dataset is on a Lambert Azimuthal Equal Area grid, which uses an ellipsoidal Earth. Randy already has some code for latlon_to_xy. The xy_to_latlon code still needs to be implemented, and the code needs to be implemented in MET (and tested accordingly).
Acceptance Testing
Same data is located on Cheyenne:
/gpfs/fs1/p/ral/jntp/AF/gswr/eumetnet (in HDF5 format)
This data can be moved to a more convenient location. Some sample data has already been shared with Randy.
Tests will need to be done to make sure the Lambert Azimuthal Equal Area projection is working as anticipated (will work with Randy to establish necessary tests).
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the new feature down into sub-issues.
No sub-issues required.
Relevant Deadlines
Goal is to target the met-10.1.0_beta1 release scheduled for 5/13/21.
Funding Source
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
New Feature Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s), Project(s), Milestone, and Linked issues
The text was updated successfully, but these errors were encountered: