Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The set_attr_accum option is setting the lead time instead of the accumulation time. #1646

Closed
7 of 21 tasks
JohnHalleyGotway opened this issue Jan 28, 2021 · 0 comments · Fixed by #1648 or #1647
Closed
7 of 21 tasks

The set_attr_accum option is setting the lead time instead of the accumulation time. #1646

JohnHalleyGotway opened this issue Jan 28, 2021 · 0 comments · Fixed by #1648 or #1647
Assignees
@JohnHalleyGotway
Labels
MET: Library Code requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Milestone
MET 9.1.2 (bugfix)

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Problem

While answering a met-help question for RT 9891 from the UK MetOffice, I tested out the set_attr options to manually define the gridded metadata. During that testing, I found that set_attr_accum does not have the desired effect. It sets the lead time instead of the accumulation interval.

It's a simple copy/paste error that's a one-liner to fix.

Expected Behavior

Defining set_attr_accum should actually override the accumulation interval read from the input data file.

Environment

Describe your runtime environment:
1. Machine: Replicated behavior on my Mac
2. OS: MacOS
3. Software version number(s): exists in met-9.1.2 and in the develop branch

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to the top-level MET directory of the develop branch and run:

bin/plot_data_plane \
data/sample_fcst/2005080700/wrfprs_ruc13_12.tm00_G212 plot.ps \
'name="TMP"; level="Z2"; set_attr_accum="37";'
-v 4

2: Note these 2 log message:

DEBUG 3: Parsed set_attr_accum = "37"
DEBUG 4:      accum time: 000000

So it parsed it correctly but did not apply it correctly.

Relevant Deadlines

None.

Funding Source

None.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: No scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: library code requestor: UK Met Office United Kingdom Met Office labels Jan 28, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1.2 (bugfix) milestone Jan 28, 2021
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jan 28, 2021
JohnHalleyGotway added a commit that referenced this issue Jan 28, 2021
@JohnHalleyGotway
Per #1646, one line fix for cut-and-paste error.
62fd0f3
@JohnHalleyGotway JohnHalleyGotway mentioned this issue Jan 28, 2021
Merged
10 tasks
This was linked to pull requests Jan 28, 2021
Bugfix 1646 main_v9.1 set_attr_accum #1648
Merged
Bugfix 1646 develop set_attr_accum #1647
Merged
JohnHalleyGotway added a commit that referenced this issue Jan 28, 2021
@JohnHalleyGotway
Per #1646, one line fix for cut-and-paste error. (#1648)
0fe2e42
JohnHalleyGotway added a commit that referenced this issue Mar 12, 2021
@JohnHalleyGotway @hsoh-u @jprestop
Update main_v9.1-ref after #1709 and #1711 (v9.1.2) (#1713)
2112920 
* Add debug level 4 message to list out the number of GRIB2 records inventoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.

* Bugfix 1554 main_v9.1 ncdump (#1555)

* Bugfix 1562 main_v9.1 grid_diag (#1563)

* Per #1562, check for bad data values before adding data to the PDF's for grid_diag.

* Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.

* Per #1508, change the verbosity in unit_tc_gen.xml from -v 2 to -v 5 to print out some additional log messages that may help in debugging the intermittent file list failure.

* Feature 1572 v9.1.1 (#1573)

* Per #1572, delete the docs/version file as it is not needed here.

* Per #1572, update the version number to 9.1.1.

* Per #1572, list the met-9.1.1 release date as 20201119 for the docs.

* Per #1572, add release notes for the met-9.1.1 verison.

* Per #1572, add release notes for met-9.1.1 version.

* Per #1572, let's try to release met-9.1.1 today 11/18.

* Correct GitHub link.

* Fix small typo in release notes.

* Bugfix 1618 main v91 pb2nc (#1622)

Co-authored-by: Howard Soh <[email protected]>

* Update pull_request_template.md

* Per #1638, apply the same 3 fixes to the main_v9.1 branch to be included in the next bugfix release for met-9.1. (#1640)

* Per #1646, one line fix for cut-and-paste error. (#1648)

* Adding necessary files for ReadTheDocs (#1703)

* Per #1706, update aggr_ecnt_lines() to also add an entry to the skip_ba array of booleans. This is used to keep track of whether or not the point should be excluded from the statistics and is used in the Ensemble-Stat. This same aggregation code in the vx_statistics library is used by Stat-Analysis. Since Stat-Analysis failed to populate that array, it led to an array parsing error in ECNTInfo::set() when trying to compute the sum of the weights. (#1707)

* Per #1694, exactly the same set of bugfix changes but applied to main_v9.1 rather than the develop branch. (#1709)

* Feature 1710 v9.1.2 (#1711)

* Per #1710, update the release notes and version numbers for the 9.1.2 release.

* Per #1710, add a release note about the move to read the docs.

Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: jprestop <[email protected]>
JohnHalleyGotway added a commit that referenced this issue Mar 20, 2021
@JohnHalleyGotway @hsoh-u @jprestop
Update main_v9.1-ref after #1730 (#1732)
eeecc49 
* Add debug level 4 message to list out the number of GRIB2 records inventoried. This helps debugging issues with MET potentially not reading all input GRIB2 records on WCOSS.

* Bugfix 1554 main_v9.1 ncdump (#1555)

* Bugfix 1562 main_v9.1 grid_diag (#1563)

* Per #1562, check for bad data values before adding data to the PDF's for grid_diag.

* Per #1562, removing the poly = CONUS.poly mask from GridDiagConfig_TMP. That settting masked a problem in the handling of missing data. Exercising the mask.poly option is tested in another unit test. This will change the output and break the nightly build, but that's good since we'll do more thorough testing.

* Per #1508, change the verbosity in unit_tc_gen.xml from -v 2 to -v 5 to print out some additional log messages that may help in debugging the intermittent file list failure.

* Feature 1572 v9.1.1 (#1573)

* Per #1572, delete the docs/version file as it is not needed here.

* Per #1572, update the version number to 9.1.1.

* Per #1572, list the met-9.1.1 release date as 20201119 for the docs.

* Per #1572, add release notes for the met-9.1.1 verison.

* Per #1572, add release notes for met-9.1.1 version.

* Per #1572, let's try to release met-9.1.1 today 11/18.

* Correct GitHub link.

* Fix small typo in release notes.

* Bugfix 1618 main v91 pb2nc (#1622)

Co-authored-by: Howard Soh <[email protected]>

* Update pull_request_template.md

* Per #1638, apply the same 3 fixes to the main_v9.1 branch to be included in the next bugfix release for met-9.1. (#1640)

* Per #1646, one line fix for cut-and-paste error. (#1648)

* Adding necessary files for ReadTheDocs (#1703)

* Per #1706, update aggr_ecnt_lines() to also add an entry to the skip_ba array of booleans. This is used to keep track of whether or not the point should be excluded from the statistics and is used in the Ensemble-Stat. This same aggregation code in the vx_statistics library is used by Stat-Analysis. Since Stat-Analysis failed to populate that array, it led to an array parsing error in ECNTInfo::set() when trying to compute the sum of the weights. (#1707)

* Per #1694, exactly the same set of bugfix changes but applied to main_v9.1 rather than the develop branch. (#1709)

* Feature 1710 v9.1.2 (#1711)

* Per #1710, update the release notes and version numbers for the 9.1.2 release.

* Per #1710, add a release note about the move to read the docs.

* #1715 Do not combined if there are no overlapping beteewn TQZ and UV records

* #1715 Do not combined if there are no overlapping beteewn TQZ and UV records

* #1715 Do not combined if there are no overlapping beteewn TQZ and UV records

* #1715 Added blank line for Warning

* #1715 Added a blank line for Error

* Bugfix 1716 main_v9.1 perc_thresh (#1721)

* Per #1716, committing the same bugfix to the main_v9.1 branch for inclusion in the 9.1.3 bugfix release.

* Per #1716, change SFP50 example to SFP33.3 to show an example of using floating point percentile values.

* Per #1723, update the verison number to 9.1.3. (#1730)

* Update pull_request_template.md

Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: jprestop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
MET: Library Code requestor: UK Met Office United Kingdom Met Office type: bug Fix something that is not working
Projects
None yet
Milestone
MET 9.1.2 (bugfix)
1 participant
@JohnHalleyGotway