fix keyboard agent str concatenation error #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using the notebook keyboard agent tutorial in the repo, there is an error with the get_move_set method of the class KeyboardAgent, at line 60 (in yawning_titan/agents/keyboard.py) ; it seems like it s trying to concatenate a network_interface.current_graph.get_nodes() object to a string into the node_list list, this change should fix it
|
I dont know what this checks stuff is and why they are failing. The fix is minimal and everything works as I am using it on my end. |
|
Hi @RiccardoGTolli. Thanks for raising this PR. The build pipeline is failing due to recent changes with pip and setuptools. When we release v2.0.0 these build errors will disappear. Happy for this PR to just be merged in now. This will remain on the dev branch until the official release of v2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the notebook keyboard agent tutorial in the repo, there is an error (TypeError: can only concatenate str (not "Node") to str) with the get_move_set method of the class KeyboardAgent, at line 60 (in yawning_titan/agents/keyboard.py) ; it seems like it s trying to concatenate a network_interface.current_graph.get_nodes() object to a string into the node_list list, this change should fix it