Add user property to run configurations
#2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If not set, use the default user from the image (if it, in turn, is not set either, Docker uses `root` as a default value) * The container user is still set to `root`, as we need root privileges, at least to install sshd, but the runner executes the job (shell script with `commands` from the run configuration) as `user`. * If the `user` is not root, it gets its own copy of `~/.ssh/authorized_keys` and `~/.ssh/environment`, making it possible to `ssh user@run-name` (the default user is still `root`, that is, `ssh run-name` logs in as root) * `~/.ssh/environment` is now generated by the runner, not the outer shell script (container entrypoint), and includes all the same variables as the job env (including `DSTACK_*` vars and vars from the `env` property of the run configuration) Part-of: #1535
|
@un-def, could you clarify if containers running as non-root work with volumes? I'd assume that host directories would need to have appropriate permissions for the non-root user in order for volumes to work. |
r4victor
approved these changes
Dec 5, 2024
pranitnaik43
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Mar 4, 2025
* If not set, use the default user from the image (if it, in turn, is not set either, Docker uses `root` as a default value) * The container user is still set to `root`, as we need root privileges, at least to install sshd, but the runner executes the job (shell script with `commands` from the run configuration) as `user`. * If the `user` is not root, it gets its own copy of `~/.ssh/authorized_keys` and `~/.ssh/environment`, making it possible to `ssh user@run-name` (the default user is still `root`, that is, `ssh run-name` logs in as root) * `~/.ssh/environment` is now generated by the runner, not the outer shell script (container entrypoint), and includes all the same variables as the job env (including `DSTACK_*` vars and vars from the `env` property of the run configuration) Part-of: dstackai#1535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rootas a default value)root, as we need root privileges, at least to install sshd, but the runner executes the job (shell script withcommandsfrom the run configuration) asuser.useris not root, it gets its own copy of~/.ssh/authorized_keysand~/.ssh/environment, making it possible tossh user@run-name(the default user is stillroot, that is,ssh run-namelogs in as root)~/.ssh/environmentis now generated by the runner, not the outer shell script (container entrypoint), and includes all the same variables as the job env (includingDSTACK_*vars and vars from theenvproperty of the run configuration)Part-of: #1535