Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example of NIM #1853

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Adding an example of NIM #1853

merged 4 commits into from
Nov 12, 2024

Conversation

deep-diver
Copy link
Contributor

Adding an example of NIM

@Bihan
Copy link
Collaborator

Bihan commented Oct 20, 2024

Hey @deep-diver,

  1. I’ve created a sample README.md that follows dstack's structure. Please note that it assumes the reader is already familiar with NIM. Feel free to update it accordingly.
  2. I tested the sample configuration with a 24GB GPU, and it worked. Kindly update the GPU requirement to 24GB.
  3. Could you also provide the source-code for the development environment (.dstack.yml), task (task.dstack.yml), and service (service.dstack.yml)

Thanks!

@deep-diver
Copy link
Contributor Author

@Bihan cc: @peterschmidt85

Sorry for delayed response, and thanks for the comments.

    1. update 48GB to 24GB is done
    1. provided service.dstack.yml since I wrote this for only deployment purpose with service.

for the first point, your README.md assumes the reader is already familiar with NIM like you said. But, I think giving a bit about the background to readers never hurts anything. Actually, I think it is a good thing.

However, if you think this violates dstack's blogging/writing policy, and this MUST be modified accordingly, feel free to adjust the contents.

@r4victor
Copy link
Collaborator

r4victor commented Nov 5, 2024

@deep-diver, @Bihan what's the status of this PR? Should we merge it?

@Bihan
Copy link
Collaborator

Bihan commented Nov 5, 2024

@deep-diver, @Bihan what's the status of this PR? Should we merge it?

@r4victor I will adjust the content till tomorrow morning and let you know.

@deep-diver
Copy link
Contributor Author

I think this is ready to be merged
cc: @peterschmidt85

@Bihan Bihan merged commit f5aa2eb into dstackai:master Nov 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants