Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python2 #114

Closed
kdheepak opened this issue Jun 9, 2022 · 1 comment · Fixed by #110
Closed

Drop support for Python2 #114

kdheepak opened this issue Jun 9, 2022 · 1 comment · Fixed by #110

Comments

@kdheepak
Copy link
Member

kdheepak commented Jun 9, 2022

What are your thoughts about dropping support for Python2?

We could remove lines like from __future__ import absolute_import like here:

from __future__ import absolute_import

There are other changes too that might open up. I wanted to solicit feedback for this before going forward with this change.

@PMeira
Copy link
Member

PMeira commented Jul 6, 2022

Yeah, we can remove those. It was effectively removed a while ago, and there were almost no downloads from 2.7 even before that.

For the new interface I started adding type annotations too: https://github.com/dss-extensions/dss_python/blob/0.12.x/dss/IObj.py

In that branch, I raised NumPy to version 1.21 because of that, but looking now it seems 1.21 supports only Python >= 3.7. Since the download numbers for 3.6 are not insignificant, it's probably better to include it until Python 3.11 is out, at least, so I'll adjust things to include it. (Nobody is using Python 3.5, so already I removed the tag.)

If nothing major happens, I will try to get the releases rolling over the weekend so we can discuss a few things and collect feedback. And maybe finish #78, since it is a requirement for multi-threading and multiple contexts.

@kdheepak, would you be available next week or so for a quick chat? I can send some material in advance.

PMeira added a commit that referenced this issue Jul 15, 2022
PMeira added a commit that referenced this issue Jul 15, 2022
PMeira added a commit that referenced this issue Jul 16, 2022
PMeira added a commit that referenced this issue Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants