Implement ingress-nginx helm release as module #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vradicevicds
commented
Sep 24, 2024
vradicevicds
commented
Sep 24, 2024
vradicevicds
force-pushed
the
cot/ingress_nginx_addon/module
branch
from
a4944c5 to
a9463fa
Compare
vradicevicds
changed the title
vradicevicds
force-pushed
the
cot/ingress_nginx_addon/module
branch
from
b7211f4 to
0a91188
Compare
tmisch
reviewed
Sep 26, 2024
sgrdn
requested changes
Sep 26, 2024
vradicevicds
dismissed stale reviews from mariogluhakovic and lukabudak
via
9fe2e1a
vradicevicds
force-pushed
the
cot/ingress_nginx_addon/module
branch
from
bb4c501 to
c321d7e
Compare
sgrdn
reviewed
Sep 30, 2024
There was a problem hiding this comment.
We should keep the provider versions "kubernetes" version = ">= 1.6.1" vs version = ">= 2.10" on the same version, but that is a task for another story.
|
If I run |
sgrdn
previously approved these changes
Sep 30, 2024
Yes, it does change for me as well. Should I add this to the commit? Perhaps we should consider adding this to quality gate as well. |
|
For me, one hash is added per provider. We could add that. |
sgrdn
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces ingress-nginx addon from terraform-aws-eks-blueprints with custom module, maintained by this repository, providing possibility for custom tweaks and changes.
Terraform v1.9.4
on windows_amd64