Implement multiline support for tfvars description #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vradicevicds
force-pushed
the
cot/tfvars_multiline_description
branch
from
056b0e7 to
7ec796a
Compare
|
Why did you pick 350 characters for cutoff limit? |
Usually there are arguments for 80, 100 and 120 characters. |
Good point. 350 is selected because there are existing descriptions with up to 350 characters, which are tolerated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for generating multiline descriptions in terraform.tfvars.example when variable description is longer than 120 characters.
If string is longer that 120 characters, string is separated into sentences (sliced on ". "). Each sentence is written in a new line, regardless the length.