Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed eks_addon lifecycle dependency on managed node lifecycle #145

Merged
merged 2 commits into from
May 24, 2024

Conversation

amarin-dspace
Copy link
Contributor

@amarin-dspace amarin-dspace commented May 23, 2024

This PR is very simple, what it does is basically in the title - it removes K8s add-ons lifecycle dependency on managed node lifecycle.
This dependency is useful on initial deployment, as it ensures faster deployment and everything is ordered (nodes are provisioned first, and then apps on top, ensuring everything is ready for clean app provisioning).
This is, however, not useful if lifecycle operations need to be performed later on, eg configuration change of managed node group(s).
The system then runs into 'catch 22' type of a problem: configuration change triggers node group re-deployment, which in turn triggers eks_addons re-deployment, but since addons contain critical apps (CNI, DNS etc.) to complete node group re-deployment, the provisioning fails.
While this solution is far from ideal, there is an ongoing effort to re-write addons module into individual resources, which would also enable the usage of lifecycle meta argument.
Other points-of-view are welcome.

@amarin-dspace amarin-dspace requested a review from schwichti May 23, 2024 08:12
@amarin-dspace amarin-dspace merged commit e991e89 into main May 24, 2024
1 check passed
@amarin-dspace amarin-dspace deleted the cot/no_depends_on branch May 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants