Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network rework #139

Merged
merged 46 commits into from
May 27, 2024
Merged

Network rework #139

merged 46 commits into from
May 27, 2024

Conversation

amarin-dspace
Copy link
Contributor

@amarin-dspace amarin-dspace commented Apr 24, 2024

Reworked to be able to deploy on pre-configured network infrastructure (VPC and subnets).
This is useful with customers which do not allow this to be created by dSpace personnel.
Input parameters are vpcId, the rest (subnets) can be either derived from it or use custom inputs (subnet IDs).
Nginx deployment can be limited to use specific subnets (public ones only).
@lukabudak prepared PR in parallel, #142, so all the changes in this PR can work with our qualitygate setup.
Tested to be working in both deployment scenarios (clean deployment with full admin rights and deployment with vpc already provisioned).

Terraform v1.7.1
on linux_amd64

  • provider registry.terraform.io/gavinbunney/kubectl v1.14.0
  • provider registry.terraform.io/hashicorp/aws v4.67.0
  • provider registry.terraform.io/hashicorp/cloudinit v2.3.3
  • provider registry.terraform.io/hashicorp/helm v2.13.0
  • provider registry.terraform.io/hashicorp/http v3.4.2
  • provider registry.terraform.io/hashicorp/kubernetes v2.29.0
  • provider registry.terraform.io/hashicorp/local v2.5.1
  • provider registry.terraform.io/hashicorp/null v3.2.2
  • provider registry.terraform.io/hashicorp/random v3.6.0
  • provider registry.terraform.io/hashicorp/time v0.11.1
  • provider registry.terraform.io/hashicorp/tls v4.0.5
  • provider registry.terraform.io/terraform-aws-modules/http v2.4.1

@schwichti
Copy link
Member

Consider to use this pattern: https://gist.github.com/schwichti/cc11a6e4826fde55b999bb3b1079e4f4#create-or-read-resources

@amarin-dspace
Copy link
Contributor Author

New requirement added: handling of only specific subnets (either via new variable or via new filtering options).
Work in progress.

@amarin-dspace amarin-dspace changed the title [WIP] Network rework Network rework May 8, 2024
data.tf Outdated Show resolved Hide resolved
network.tf Show resolved Hide resolved
network.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
locals.tf Outdated Show resolved Hide resolved
data.tf Show resolved Hide resolved
license-server.tf Outdated Show resolved Hide resolved
storages.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@lukabudak lukabudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase your branch with main in order to apply terraform-docs changes

storages.tf Show resolved Hide resolved
license-server.tf Show resolved Hide resolved
@amarin-dspace
Copy link
Contributor Author

Rebase your branch with main in order to apply terraform-docs changes

Done and qualitygate already picked up the null value and commited it correctly - good work!

lukabudak
lukabudak previously approved these changes May 23, 2024
Copy link
Contributor

@lukabudak lukabudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT regarding the terraform-docs null "issue"

sgrdn
sgrdn previously approved these changes May 23, 2024
Copy link
Member

@schwichti schwichti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarin-dspace amarin-dspace merged commit 6254b77 into main May 27, 2024
1 check passed
@amarin-dspace amarin-dspace deleted the cot/deploy_into_existing_subnets branch May 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants