-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network rework #139
Network rework #139
Conversation
…rrently not used)
Consider to use this pattern: https://gist.github.com/schwichti/cc11a6e4826fde55b999bb3b1079e4f4#create-or-read-resources |
New requirement added: handling of only specific subnets (either via new variable or via new filtering options). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase your branch with main in order to apply terraform-docs changes
Done and qualitygate already picked up the null value and commited it correctly - good work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT regarding the terraform-docs null "issue"
This reverts commit 9e602d1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reworked to be able to deploy on pre-configured network infrastructure (VPC and subnets).
This is useful with customers which do not allow this to be created by dSpace personnel.
Input parameters are vpcId, the rest (subnets) can be either derived from it or use custom inputs (subnet IDs).
Nginx deployment can be limited to use specific subnets (public ones only).
@lukabudak prepared PR in parallel, #142, so all the changes in this PR can work with our qualitygate setup.
Tested to be working in both deployment scenarios (clean deployment with full admin rights and deployment with vpc already provisioned).
Terraform v1.7.1
on linux_amd64