Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for autoscaler after qualitygate re-enable #135

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

amarin-dspace
Copy link
Contributor

@amarin-dspace amarin-dspace commented Apr 9, 2024

After qualitygate was fixed in #131 , default autoscaler version was pulled from variables.tf (which references old registry and does not work - fixed in #123 , but put only in tfvars) and persisted in re-generated terrform.tfvars.example file (as part of qualitygate process).

This PR puts minimum default (working) version in variables.tf to avoid this situation; use tfvars file to adapt to your specific deployment, if necessary.

@amarin-dspace amarin-dspace changed the title [WIP] Fix for autoscaler after qualitygate re-enable Fix for autoscaler after qualitygate re-enable Apr 9, 2024
Copy link
Contributor

@mariogluhakovic mariogluhakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariogluhakovic mariogluhakovic merged commit f7c3c3c into main Apr 10, 2024
1 check passed
@mariogluhakovic mariogluhakovic deleted the cot/autoscaler-default-version-fix branch April 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants