Cber/switch for nginx metrics #127
Conversation
|
Can you elaborate a bit why we need a switch for the metrics? |
|
Maybe it's for the best, since we currently depend on simphera-monitoring helm chart to deploy necessary CRDs, in order to have metrics enabled and deployed with nginx helm chart. |
|
Yes, the case is, that our infrastructure creations fail because of the "metrics enabled" values in the nginx_values.yaml. By default they would still be enabled, but we as SystemTeam do not use this feature currently. |
This reverts commit 5af598b.
…pace-group/simphera-reference-architecture-aws into cber/switch_for_nginx_metrics
…pace-group/simphera-reference-architecture-aws into cber/switch_for_nginx_metrics
variables.tf
Outdated
| @@ -257,3 +257,8 @@ variable "cluster_autoscaler_helm_config" { | |||
| default = {} | |||
| } | |||
|
|
|||
| variable "enable_nginx_metrics" { | |||
| type = bool | |||
| description = "Switch to enable the metrics in the nginx values" | |||
There was a problem hiding this comment.
"Switch to enable nginx metrics"?
variables.tf
Outdated
| variable "enable_nginx_metrics" { | ||
| type = bool | ||
| description = "Switch to enable the metrics in the nginx values" | ||
| default = true |
There was a problem hiding this comment.
Maybe to have it 'false' by default and put a small update to README file?
There was a problem hiding this comment.
I mean, have the var present, but set its default value from 'true' to 'false'
|
LGTM, as we agreed in discussion with SimonS, we'll abandon these changes in TF and move nginx metrics' part completely to Simphera monitoring chart. |
Adds a switch to be able to disable the metrics in the nginx_values.yaml