Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmsReceive: Deal with fixed number addition random number context #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hongnod
Copy link

@hongnod hongnod commented Nov 29, 2019

Some SMS number will append random number on a fixed number, so save the fixed part ,if fixed part matches, process the transition.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@yetanothercoder
Copy link
Contributor

it can break existing functionality: consider you have 2 sms templates for 900 tel number and for 9001 - then the 9001 one can never be selected and 900 will be always triggered instead.

@hongnod
Copy link
Author

hongnod commented Dec 4, 2019

Yes, that case has such problem. but in reality, we don't have such kind of number.if actually has, define 9001 template as another 900 is enough.

@hongnod
Copy link
Author

hongnod commented Dec 4, 2019

#127 post a new request, maybe fix this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants