allow transactions to specify an identifying field accordproject#21

Signed-off-by: Dan Selman <[email protected]>
dselman · Oct 28, 2018 · f1c2ae1 · f1c2ae1
1 parent 4ace003
commit f1c2ae1
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 21 deletions.
diff --git a/lib/introspect/transactiondeclaration.js b/lib/introspect/transactiondeclaration.js
@@ -67,10 +67,6 @@ class TransactionDeclaration extends ClassDeclaration {
             systemTypeDeclared = hasSystemType;
         }
 
-        if (!this.isSystemType() && this.idField && systemTypeDeclared) {
-            throw new IllegalModelException('Transaction should not specify an identifying field.', this.modelFile, this.ast.location);
-        }
-
         // perform general validation after specific validation.
         super.validate();
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/introspect/transactiondeclaration.js b/test/introspect/transactiondeclaration.js
@@ -59,21 +59,5 @@ describe('TransactionDeclaration', () => {
             td.validate();
 
         });
-
-        it('should cover the other error paths', () => {
-            const model = `
-            namespace org.acme
-            transaction T identified by id{
-               o String id
-            }
-            `;
-
-            const modelFile = new ModelFile(modelManager, model);
-            let td = modelFile.getTransactionDeclaration('T');
-
-            (() => {
-                td.validate();
-            }).should.throw(/Transaction should not specify an identifying field./);
-        });
     });
 });