Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xBitLocker: Fix hashtables according to the style guideline #53

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 29, 2019

Pull Request (PR) description

  • Changes to xBitlocker
    • Fix hashtables according to the style guideline.

This Pull Request (PR) fixes the following issues

None. Recently merged PSSA custom rules in the test framework would fail the tests unless these are resolved.

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

- Fix hashtables according to the style guideline.
@johlju johlju changed the title xBitLocker: Fix hashtables according to the style guideline. xBitLocker: Fix hashtables according to the style guideline Oct 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #53 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #53   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         3      3           
  Lines        96     98    +2     
===================================
+ Hits         96     98    +2
Impacted Files Coverage Δ
...s/MSFT_xBLAutoBitlocker/MSFT_xBLAutoBitlocker.psm1 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb676e...b6971ef. Read the comment docs.

Copy link
Contributor

@mhendric mhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mhendric
Copy link
Contributor

Thanks for the contribution @johlju !

@mhendric mhendric merged commit 24a835b into dsccommunity:dev Oct 29, 2019
@johlju johlju deleted the fix-hashtables branch September 11, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants