-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Windows "Client" OS support. Fixes #47 #49
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #49 +/- ##
===================================
Coverage 100% 100%
===================================
Files 3 3
Lines 96 96
===================================
Hits 96 96 Continue to review full report at Codecov.
|
Hi @mnothh , thanks for the submission. And sorry for the late response, as I've been on vacation. I'll get this code reviewed ASAP. |
Hi @mnothh, what specific Windows and PowerShell version did you test this on? This doesn't work on my Win10 machine. I have to add -Online and -FeatureName, and also need to look at the .State property, not the .InstallState property.
Here's it working:
|
Hey @mhendric. You are likely correct. I believe this was tested on 1709(off the top of my head). I'm currently out of office as well. As soon as I have access to my test machines I'll rework this to confirm it is compatible with newer releases as well. |
Pull Request (PR) description
Added support for Windows "Client" operating systems in the
Assert-HasPrereqsForBitlocker function.
This Pull Request (PR) fixes the following issues
-Fixes #47
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is