Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple style issues #44

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Fix multiple style issues #44

merged 2 commits into from
Nov 29, 2018

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Nov 27, 2018

Pull Request (PR) description

  • Change double quoted string literals to single quotes
  • Add spaces between array members
  • Add spaces between variable types and variable names
  • Add spaces between comment hashtag and comments

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@mhendric mhendric added the needs review The pull request needs a code review. label Nov 27, 2018
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #44 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #44   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         3      3           
  Lines        96     96           
===================================
  Hits         96     96
Impacted Files Coverage Δ
...Resources/MSFT_xBLBitlocker/MSFT_xBLBitlocker.psm1 100% <ø> (ø) ⬆️
DSCResources/MSFT_xBLTpm/MSFT_xBLTpm.psm1 100% <ø> (ø) ⬆️
...s/MSFT_xBLAutoBitlocker/MSFT_xBLAutoBitlocker.psm1 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7799ad...0c8849a. Read the comment docs.

@mhendric mhendric merged commit 23a4075 into dsccommunity:dev Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Bad Quote Styles
2 participants