Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for All Resource Modules #41

Merged
merged 6 commits into from
Nov 21, 2018
Merged

Add Integration Tests for All Resource Modules #41

merged 6 commits into from
Nov 21, 2018

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Nov 21, 2018

Pull Request (PR) description

Add Integration Tests for All Resource Modules

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #41 into dev will decrease coverage by 12.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            dev     #41      +/-   ##
=======================================
- Coverage   100%   87.5%   -12.5%     
=======================================
  Files         3       3              
  Lines        96      96              
=======================================
- Hits         96      84      -12     
- Misses        0      12      +12
Impacted Files Coverage Δ
...Resources/MSFT_xBLBitlocker/MSFT_xBLBitlocker.psm1 7.69% <0%> (-92.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4f036...bad0420. Read the comment docs.

@mhendric mhendric merged commit 2b06229 into dsccommunity:dev Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Tests from Test-xBitlocker.ps1 to an Appropriate Integration Test Template
2 participants