Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource module to standard #15

Merged
merged 10 commits into from
May 28, 2018
Merged

Update resource module to standard #15

merged 10 commits into from
May 28, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented May 28, 2018

  • Changes to xBitlocker
    • Added Codecov support.
    • Updated appveyor.yml to use the one in template.
    • Added folders for future unit and integration tests.
    • Added Visual Studio Code formatting settings.
    • Added .gitignore file.
    • Added markdown lint rules.
    • Fixed encoding on README.md.
    • Added PowerShellVersion = '4.0', and updated copyright information, in the
      module manifest.

This change is Reviewable

johlju added 10 commits May 28, 2018 09:05
- Updated appveyor.yml to use the one in template.
- Added folders for future unit and integration tests.
- Added Visual Studio Code formmatting settings.
- Fixed encoding on README.md.
- Added `PowerShellVersion = '4.0'`, and updated copyright information, in the
  module manifest.
@johlju
Copy link
Member Author

johlju commented May 28, 2018

:LGTM:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@f718d81). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #15   +/-   ##
=====================================
  Coverage       ?   3.48%           
=====================================
  Files          ?       3           
  Lines          ?      86           
  Branches       ?       0           
=====================================
  Hits           ?       3           
  Misses         ?      83           
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f718d81...ef0e850. Read the comment docs.

@johlju johlju merged commit 9b00d76 into dsccommunity:dev May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants